From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751672AbdI1UHe (ORCPT ); Thu, 28 Sep 2017 16:07:34 -0400 Received: from mail-co1nam03on0055.outbound.protection.outlook.com ([104.47.40.55]:20203 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750832AbdI1UHc (ORCPT ); Thu, 28 Sep 2017 16:07:32 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aduggan@synaptics.com; From: Andrew Duggan To: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andrew Duggan , Dmitry Torokhov , Benjamin Tissoires , =?UTF-8?q?Kamil=20P=C3=A1ral?= Subject: [PATCH] Input: synaptics - Disable kernel tracking on SMBus devices Date: Thu, 28 Sep 2017 13:07:19 -0700 Message-Id: <1506629239-5940-1-git-send-email-aduggan@synaptics.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Originating-IP: [192.147.44.15] X-ClientProxiedBy: CY4PR0601CA0081.namprd06.prod.outlook.com (52.132.96.150) To CY4PR03MB2581.namprd03.prod.outlook.com (10.173.42.12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bf008efa-10ae-4a90-c13d-08d506ac8c52 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:CY4PR03MB2581; X-Microsoft-Exchange-Diagnostics: 1;CY4PR03MB2581;3:yQTA7G37v1YmZrjwuLGJYizhbuC/v8sATtTML8v+sdtcXCH6nsWD55GLifhGawsbtjkKqnIn4qvs7XF/5yr/dSa9JB4jmV2sW4fB5Uocua9udz7F5u9AVNbHHrd8w3ob+Mt8CjOp0YBQsZaqkf6DCq4n9dcSfYAYkZKM2W+oH/m3NLK2DmrwrPCEuLol6AqAyB4BNzboHgjNEGgttmToesLfbJkZ2yClaqlxecZ4mkKVuq2fCyOQkcl3UoOnMp38;25:EK6X9GFMadlemnD/q5/W1IK3qxflEGGDZl7VhtlH5PqYnWhmatl+M/plXGPeoOAXHzWjT8i0ZcblsIRUnSS1kt91DEG4xwuiajiHlQ8a5i261TyW5tGvbbDnJoPzbvviDs2XtOAE2WT/5k5ABEOVoYSVtaB2GnFb8qSGCh3zFlypTWTkSHw6DrdkMKyM2QO1PO1fplpxM2a6jBM6tEoiq+QEItxuavsN0+c9Pj1ZitxeI71d4sg4jVGDzM2S7tQhKKR5kDhOfUjJyODtcN1rJ0jcQI7c9X9tc4yR1zYQrdB8NDSOfTZiX5XCOSNdxChdAgk5rTHIkAsr5znsOkjGWA==;31:VvExDLLMbMPMvD8rkEnQi/8LAiZh+FxisuUPNjzGw4t6v+AVB4EwFCuYuSjnRUPAfblQbAnMjJTSR8CRmpmq5M1/rW3MUYXJN4qj2ZA6irxB+cG/frE/GLEyr1/9LMfLMRmylNkp6+Sms1xCj2a3InSqI9pY9QOhYJrL9fsCptfbEe+T1P+Qykf/A//5YK0x1KKlCd4zMcqCgjHaTzLs+9QAVPEr7rdpALpGgWGqGOI= X-MS-TrafficTypeDiagnostic: CY4PR03MB2581: X-Microsoft-Exchange-Diagnostics: 1;CY4PR03MB2581;20:2iH+A4JW2QAqNk9J5CypTpRphjQunYcsC2CQ9PC+A6b+wCTmOEIKMO51XM2Kp+m3dYLvCWNBLlDdykWnZiUsNN6DcTbjEd9zgFYbNVY1PAQmo5BBADZkMIHjVvEF85bNdsbOZ+5I1WKLC5BND8xvXpX4lLEr+SHYSVThnCQnMTU14h/3JvVCdKCIO+dB434E6Urh0BL8fCvKwAj2DBesMBaZOc95hQQi/cZqLlIxT4Gg5pW9/e737ZyVxq4rEEGQYR7lWIw36/W2X1Nt8tXbWcxwc0UfWPTv+71FOaJhW26bFtVyj/ijRcjNdRV0DJYJLNwDw9WoRaY3f0N4tW+zLmQA1BAJ0Tpt1jbqVdOM74ha2G+Gt8Oq2NMdF+QdDqhmWKDpeI8A62BpVw/BbTnrfCjMC3u8amL5HC6ijJDrjJQ=;4:CgFsHII5qf4RtPIRn0K3k5WNOri9ugQuo2S/Fo2kW8W/pFU9k1OfCB5CvzxPc5In2Sad7Rsu+SR+pZ5i5KjNSwbQiM98/XxSKbXFQFMPH3pGWik+FQuZlWq0Ay38hjtYhKU9Qe4wPkUoInLXCEaPta5N9vznF3dZXOUrM/vGojCjuvz4D3wq88Lgdt5jTXTcQycIWVmhxblhslxJOSbw7zS6+36QAxFeEcUW2ZJ6XvFz2L5kdJ6/kH4BMW+c593/3pJ6Z12pWKEZXkS3wxG660VsXOjvSKhCI1gmNsjj8U7UoDP1QdCTVQXAcc0RjvGKWvcysHzo33xNRruo2vP0KgsY9PNl7rOTDJxN3oTJ0NwJ2AIxciYPPGImsXd5gFQh X-Exchange-Antispam-Report-Test: UriScan:(20558992708506)(83566789882024)(211171220733660); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(6041248)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY4PR03MB2581;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY4PR03MB2581; X-Forefront-PRVS: 0444EB1997 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(376002)(39830400002)(346002)(189002)(199003)(50466002)(25786009)(50986999)(6506006)(6486002)(97736004)(478600001)(66066001)(316002)(47776003)(54906003)(23676002)(966005)(16526017)(3846002)(53936002)(189998001)(33646002)(86362001)(6116002)(575784001)(4326008)(6512007)(6306002)(5660300001)(8936002)(2870700001)(81166006)(81156014)(8676002)(105586002)(39060400002)(6666003)(7736002)(68736007)(305945005)(50226002)(2906002)(106356001)(36756003)(101416001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR03MB2581;H:noble.synaptics-inc.local;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjAzTUIyNTgxOzIzOlRkOG1VZkJ2STZvUGZ4b1dNNkRNUFRaeUVX?= =?utf-8?B?Nm96cmdyTWVOV2VTWmU5YUEwZ0E0VlhKYk0xL1hMZkZwcjV1VnBqa01JdGda?= =?utf-8?B?VldwckljVkd3eHFJTVJXSXVtcjV1V0Z0TTEyaTZvZVBWOWVWdE1nVDdXd0dF?= =?utf-8?B?Nm12SzRiRVZ4elFEdEV0QXB2NXFhSFlsRUhzR3pUUjJIRVlmb0ZMN3hGSFVC?= =?utf-8?B?QlNpRGxwQzBmSXVTQkM4bmF1cnRiMzMzaE1vUUo4ZEprTHhaSjJWVHM1Sm9w?= =?utf-8?B?MEU5b05wMWpBaEpXcURBb3BqRWVuaEtOV3poYWg4aUFwaE9uYXc5dWl3Y0pn?= =?utf-8?B?SVhKRkVoakFQTGtaUWR3SlNkak12TlpnUys2RWFCK3VFdXlpY2luOGdIb2pL?= =?utf-8?B?cGFvMWRTSTY4STJmbm1lWGZjRU5pcnBXU1A4OTcrTGcxU3dMbU5oWVorSkpv?= =?utf-8?B?MXhUZk1kSGRFVnphakJ2eVFZM1Noa1FTTGtTTkJRU1hXT2IveWd6SlhtZndz?= =?utf-8?B?NzZQcEpXVU1ITk9UWThna3dzRHpmZHNVRWxIVUE0cUI0OWRScWxVTU1Ca0oz?= =?utf-8?B?dThsY2hzUDE3UzBqWWhicHhnTVFRT1hPM2w2cW5zNW1NeDJ6bGNQSDlTNjdW?= =?utf-8?B?MlJkTEhVajZ2KytpRlZlS2o4VUkrZEdOUXpCczNYcnc3aGVEZ0VIbHl0cWd5?= =?utf-8?B?a09Fa0RkUkhLSjlqZlhmakoyZUVjTVdvSU1DaTFseUxvTHd2S2lQUGgrclV4?= =?utf-8?B?TU81cE1RR0J4RTdUYmhBMTV5K2lEN0J0SFRxN0xJWkxtWlBxeUp1cUxYMTU0?= =?utf-8?B?bENEY05wYzh5QXp5a3Nja1VXMnJVRTFDR3lIaFE3UGhDZUphMGpmdWJyNkRj?= =?utf-8?B?ejJwT2NXeG5nOGlUdHV2VkErYUw4c05YWW1VMFgwd1pZcDZ0OExNb0M0T0pB?= =?utf-8?B?OTZOL3c3cEZXZ2J6d0U4N20xWjBMVnZiVTJ0aC8rWWNMa0pBNkZJaUxhbnE1?= =?utf-8?B?Y2x6UnRaeFNGS3dFU2wxcFVsZmo1YXZZcjhtUDExUGlkRUNBbXRJaDRHdzJG?= =?utf-8?B?bkxwZTJqcEg2Q2haS1QzVmdOQzk5c3RBVzN2SHBMV2dlQ2libXNwNzcxUTUr?= =?utf-8?B?VGJ4SGIvMUk5eUZ0b0hEN1J0ei9INm9FZzNiMzNGQkUzdUJld3lzSkhYSEh5?= =?utf-8?B?Z2t3Wi9sQXhlOUdhV0dPN1lWMVhXMXdLZmY3TWFVcDcxemE5MlVNUm00QVZk?= =?utf-8?B?TC91ZGZITVI5dVJYV3kvL3ovbk5IZmUwd2ZqTE5KWFJRbyt4Zk9pQnBFR0R3?= =?utf-8?B?Q3ptSGFVMjNsVE9VTll6YVpVdTVQSHJiZ1FiN2VkNitxd0NCRkd2dEFwV0Fs?= =?utf-8?B?ZjRZakg2NlhmOXJsSmU5OXlVTlhMajU4d3NFdjFLd2J0WHhxT0lnQ2lNRkdq?= =?utf-8?B?VDJYOC9ZbEFrTDFxOFVwbWN6akNYOWhjTWdaRkNlNkdoT1VWUU9JWS9tV3Vo?= =?utf-8?B?Tm5Udz09?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR03MB2581;6:pFftvLPz8tQmOUqq0XbcdUchlulKK+9gsr0SrocJPN/74A1hViowcfi0xFRIv9LJwSrFEvFRCc2ynflUKapknHr3p4gGcsTc8/blahzXj9xcNgtdWvwPz9bNassCdMvnJVIDXpUdaKlMUz8PB+Wx6WcwroTKTtVrvqDPWSZrh+P2nugFdQkMyCwT6C6xrpM+yeSS6AsjxRh1mSKA+VOBRaFMxs9ebud86uQ8BZqVBDGidRfYAubSStXQAdo4r8FLiezhQUhDZAwVozq/IIPmbIwTIRfu8XKlJdHn12xJ3MSFVTC9A+cGogmcAHuNPUNknThnMymiZK+rRHj3hW/arg==;5:7iFkfm+oKvecI/TE4c0hWoiNrZOYtibgY1n/2fiy0sByuAg2NwKHdJrAOScrv8IwF4NkzttuWypOCYqIx95S9CQrYuXIyE2qMDnOmp2QkgQhfVsD8zDUAFbQIlxxKCnnvB4lIuquQm5SN5Ni9CYnvA==;24:hmtgMkD+ewVhQo4Iz5GQJW0aBddmEruyxG0I7rlwtJGDt6K7/MuwYhibAdWmI/DHVRKo5qBNHlxcHjBCoIzJ/RVsvY5/O6yTY0I0lMpTybY=;7:e6W57Y6LvnhQzYKIgN/q/V4nT6SVZsdYQSGFAQBh/1YD0mYqWcZ1aAVEBtKLuygZzvhdipRlPmTcKEUyi7yLVy285UL/rJG2A6FNSyUnTomb/P9GT60sImxZ+76FQ35H9XgIkHuPsEFXGRsslZBsHrWf88L3kmIF/xi96RoCyX2ZD/UfFO67/Udo79MFBfBE9vM6xmKjOLLayuntbeAP9f1jtfz/CzINMGnri34gmwg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: synaptics.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2017 20:07:29.8668 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335d1fbc-2124-4173-9863-17e7051a2a0e X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2581 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In certain situations kernel tracking seems to be getting confused and incorrectly reporting the slot of a contact. On example is when the user does a three finger click or tap and then places two fingers on the touchpad in the same area. The kernel tracking code seems to continue to think that there are three contacts on the touchpad and incorrectly alternates the slot of one of the contacts. The result that is the input subsystem reports a stream of button press and release events as the reported slot changes. Kernel tracking was originally enabled to prevent cursor jumps, but it is unclear how much of an issue kernel jumps actually are. This patch simply disabled kernel tracking for now. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1482640 Signed-off-by: Andrew Duggan Tested-by: Kamil Páral --- drivers/input/mouse/synaptics.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index 5af0b7d..ee5466a 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c @@ -1709,8 +1709,7 @@ static int synaptics_create_intertouch(struct psmouse *psmouse, .sensor_pdata = { .sensor_type = rmi_sensor_touchpad, .axis_align.flip_y = true, - /* to prevent cursors jumps: */ - .kernel_tracking = true, + .kernel_tracking = false, .topbuttonpad = topbuttonpad, }, .f30_data = { -- 2.7.4