From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752178AbdI2PyF (ORCPT ); Fri, 29 Sep 2017 11:54:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6813 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751975AbdI2PyE (ORCPT ); Fri, 29 Sep 2017 11:54:04 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 10C5080B22 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dledford@redhat.com Message-ID: <1506700441.2919.25.camel@redhat.com> Subject: Re: [PATCH V2 for-next 3/8] RDMA/hns: Add return statement when kzalloc return NULL in hns_roce_v1_recreate_lp_qp From: Doug Ledford To: "Wei Hu (Xavier)" Cc: linux-rdma@vger.kernel.org, lijun_nudt@163.com, oulijun@huawei.com, charles.chenxin@huawei.com, liuyixian@huawei.com, xushaobo2@huawei.com, zhangxiping3@huawei.com, linuxarm@huawei.com, linux-kernel@vger.kernel.org, shaobohsu@163.com Date: Fri, 29 Sep 2017 11:54:01 -0400 In-Reply-To: <1506697814-98432-4-git-send-email-xavier.huwei@huawei.com> References: <1506697814-98432-1-git-send-email-xavier.huwei@huawei.com> <1506697814-98432-4-git-send-email-xavier.huwei@huawei.com> Organization: Red Hat, Inc. Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 29 Sep 2017 15:54:04 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-09-29 at 23:10 +0800, Wei Hu (Xavier) wrote: > When lp_qp_work is NULL, it should be returned ENOMEM. This patch > mainly adds the error checking branch, modifies the return value of > the function named hns_roce_v1_set_mac that calling > hns_roce_v1_recreate_lp_qp. > > Ihis patch fixes the smatch error as below: ^^^^ Typo, but I can fix it, no need to respin. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD