From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752264AbdI2QW7 (ORCPT ); Fri, 29 Sep 2017 12:22:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39254 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752006AbdI2QW6 (ORCPT ); Fri, 29 Sep 2017 12:22:58 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E95FEC04AC48 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dledford@redhat.com Message-ID: <1506702175.2919.28.camel@redhat.com> Subject: Re: [PATCH V2 for-next 0/8] Bug fixes & Code improvements in hip06 and hip08 RoCE driver From: Doug Ledford To: "Wei Hu (Xavier)" Cc: linux-rdma@vger.kernel.org, lijun_nudt@163.com, oulijun@huawei.com, charles.chenxin@huawei.com, liuyixian@huawei.com, xushaobo2@huawei.com, zhangxiping3@huawei.com, linuxarm@huawei.com, linux-kernel@vger.kernel.org, shaobohsu@163.com Date: Fri, 29 Sep 2017 12:22:55 -0400 In-Reply-To: <1506697814-98432-1-git-send-email-xavier.huwei@huawei.com> References: <1506697814-98432-1-git-send-email-xavier.huwei@huawei.com> Organization: Red Hat, Inc. Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 29 Sep 2017 16:22:58 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-09-29 at 23:10 +0800, Wei Hu (Xavier) wrote: > This patch-set introduces some bug fixes and code improvements > for hip06 and hip08 RoCE driver. It includes a patch for fixing > the assign algorithm of qp_attr->max_rd_atomic and > qp_attr->max_dest_rd_atomic, three patches for static check errors, > one for setting attr mask, one for returning RoCE device ah_attr > type when querying qp, one for unregistering inet addr, and the > last one for command queue delay processing in hip08 driver. > > Lijun Ou (6): > RDMA/hns: Modify the value with rd&dest_rd of qp_attr > RDMA/hns: Factor out the code for checking sdb status into a new > function > RDMA/hns: Set mask for destination qp field of qp context > assignment > RDMA/hns: Set rdma_ah_attr type for querying qp > RDMA/hns: Remove unnecessarily calling unregister_inetaddr_notifier > function > RDMA/hns: Replace usleep_range with udelay when checking command > status > > Wei Hu (Xavier) (2): > RDMA/hns: Add return statement when kzalloc return NULL in > hns_roce_v1_recreate_lp_qp > RDMA/hns: Add return statement when checking error in > hns_roce_v1_mr_free_work_fn > > drivers/infiniband/hw/hns/hns_roce_device.h | 3 +- > drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 131 +++++++++++++++++- > ---------- > drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 9 +- > drivers/infiniband/hw/hns/hns_roce_main.c | 18 ++-- > 4 files changed, 96 insertions(+), 65 deletions(-) Hi Wei, I've taken this series into for-next. However, a lot of the commit subjects needed fixing up (and a few of the commit logs as well for general readability). Please don't use such long subjects as they interrupt the output of git log --oneline when using the kernel standard 12 digit hex output for commit hashes. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD