From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751527AbdJARkm (ORCPT ); Sun, 1 Oct 2017 13:40:42 -0400 Received: from smtprelay0093.hostedemail.com ([216.40.44.93]:40499 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751247AbdJARkk (ORCPT ); Sun, 1 Oct 2017 13:40:40 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:967:973:988:989:1260:1263:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2525:2553:2560:2563:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3622:3653:3865:3866:3867:3870:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6117:8599:8985:9025:9388:10004:10049:10400:10848:11232:11658:11914:12043:12555:12682:12740:12760:12776:12895:13069:13160:13229:13255:13311:13357:13439:13618:14107:14181:14659:14849:21080:21212:21627:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: stick77_5ce9cf409e14d X-Filterd-Recvd-Size: 1777 Message-ID: <1506879637.2274.5.camel@perches.com> Subject: Re: [PATCH v3 03/13] perf report: create real callchain entries for inlined frames From: Joe Perches To: Milian Wolff , Jiri Olsa Cc: acme@kernel.org, Linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , Namhyung Kim Date: Sun, 01 Oct 2017 10:40:37 -0700 In-Reply-To: <1648232.PM1aBqIB3I@agathebauer> References: <20170906135501.306-1-milian.wolff@kdab.com> <20170906135501.306-4-milian.wolff@kdab.com> <20170919122711.GA13388@krava> <1648232.PM1aBqIB3I@agathebauer> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2017-10-01 at 14:37 +0200, Milian Wolff wrote: > On Dienstag, 19. September 2017 14:27:11 CEST Jiri Olsa wrote: [] > > nit, think we prefer the /* */ comment style > > I'll fix this, but note that there are more places outside this patch series > where this style has crept in. Some of them also from past patches of mine - > sorry for that. I think c99 comments are fine. So did Linus Torvalds. http://lkml.iu.edu/hypermail/linux/kernel/1607.1/00627.html > I looks to me as if the checkpatch.pl should catch this, but it doesn't for me > which is odd. Does anyone know what I need to do to enable the C99_COMMENTS > check? Modify checkpatch my $allow_c99_comments = 1; change the 1 to 0 Add a runtime option if you want.