From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751442AbdJBJ4j (ORCPT ); Mon, 2 Oct 2017 05:56:39 -0400 Received: from mail-he1eur01on0058.outbound.protection.outlook.com ([104.47.0.58]:19808 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751315AbdJBJ4S (ORCPT ); Mon, 2 Oct 2017 05:56:18 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ed.blake@sondrel.com; From: Ed Blake To: tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com Cc: linux-kernel@vger.kernel.org, Ed Blake Subject: [PATCH 3/4] irqchip: imgpdc: Set sys wake polarities to active high Date: Mon, 2 Oct 2017 10:55:58 +0100 Message-Id: <1506938159-466-4-git-send-email-ed.blake@sondrel.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1506938159-466-1-git-send-email-ed.blake@sondrel.com> References: <1506938159-466-1-git-send-email-ed.blake@sondrel.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [195.88.9.101] X-ClientProxiedBy: DB6PR07CA0121.eurprd07.prod.outlook.com (2603:10a6:6:16::14) To AM4P191MB0001.EURP191.PROD.OUTLOOK.COM (2603:10a6:200:64::9) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d0a6373a-93bf-4a49-8875-08d5097bd24e X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:AM4P191MB0001; X-Microsoft-Exchange-Diagnostics: 1;AM4P191MB0001;3:8MqOuSbfxkRNMAv+vdipj0TSZ40LqsyTxHDU4G3sZ5C+Uv2RKDK6DzaVVwKEJf8bprztbF5enzbMg8gU2nWtMwyB7dQanDAB8qGBEMXZxiO1wYCw2G8SEAoogYGt4sXlFes40ABTkfoTL096CCJnCmQU6hnslgVCdEQKbzER0fDp/2/I4AFOIQniz9F01lQqh4Mk8s8z4Q46OGKy+0UvqUvmOfTk1Sjz6cCxoxHIEQEGM/HtfUfpHjYm44Q/7JyY;25:IupjB2PuvobqlV5GBiQDtXzCFh9CgGENqyHqEWA05xA6ZFl9sd4c3it2pwZzSO0Oz0CNSQR732sklmTwD95DD5Ixs5M6rXmHeUIsCqFYQgBJ9vdM4W8yDlGKz/IRv2PH9QfRFjrHrY72+aj/77IjvubieYiy4O1ADfiCrxHsz1ilNoY2sy5yLNHRZ35qeDYl90TNDelmhJIHUw+dRRCb4I8JZzABi/f18vTpFaT/hQ47J0BC2EwCcw5yFHmqR+uvHHDZObncJG0pu9JFeUJwUeyt5LLv99wmQUPYCNboZq+2VnGynR1N8xB2aZdSjMrI15sLFi8fdk3SC1lJAVX1yA==;31:RJh+M2Bp4GEQtX73JPuMxRV1a+fZUu5avLHgMD087GhMlIKxwowZmi1uaDgFBH5sW65/0p4H0sAcVx0BaECfrvtjKgUZT49NafJ99a5nAAREi0IkxVceJ2zH2URMX1PJ9q2DH3q4DWPsEO0Zfq0upegAz5qMl8dsydm3z8eQGWcPMia+wO2NtmtuXJ/gQWvn+yoNRWdWqnppcNirVO6gSN8r2lkoE3wc+qeCHQXmUcQ= X-MS-TrafficTypeDiagnostic: AM4P191MB0001: X-Microsoft-Exchange-Diagnostics: 1;AM4P191MB0001;20:vjkaGMcgSX3Dk+xaZ78WqqGmbacHrpopd9SVl/KvH84PDuBVJqQa4zbFFHG5m+EkYKVk6IfPwD0gh8nURaqsbwGcp3iEs4iK6G/+w5RehZQEJvXvIVawyttR+JydmLFxl2tXB4JBTU+e9PnDjl3URNLAG92hzs2/+l/4Nu7TVJAv/mwihbHxOK9/gpR590Qamn9MlgDRexl8iPwCcEJhYLqPlsp9d2xyZwKQY/2ePGUcDRx2rMONjui8ACwcjV9M;4:KPlQNXnIY+s1hh+tX3tJHLbM4jXxasb3Zj/CKf5Zo7tk1XmGqDXcHVqgvp427n2/eLHrVX8O6J0/iwrvj8Z4Ea5J3wpihDhW+6duNKdhuIjB/qh7igEpCp7SgOAKj1QpwvWEyNYxqCISXZdYoWFx3ThvkpmdhUYolwlsRwE/PRsS2bKr9nh5j2bPTUIedd8UMNU09tUYvXgKC8c2Bhjlss07pW5Drc6ITQAiGsnP1KqJAJg7ZC9Ey/5XfpwY14Za X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(3002001)(93006095)(93001095)(10201501046)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123560025)(20161123555025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AM4P191MB0001;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AM4P191MB0001; X-Forefront-PRVS: 0448A97BF2 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(376002)(39830400002)(346002)(199003)(189002)(66066001)(47776003)(6666003)(6116002)(3846002)(97736004)(69596002)(76176999)(50986999)(4326008)(5660300001)(101416001)(6486002)(107886003)(8936002)(8676002)(81166006)(81156014)(50226002)(5003940100001)(189998001)(68736007)(53936002)(305945005)(7736002)(50466002)(48376002)(25786009)(36756003)(2906002)(2950100002)(106356001)(105586002)(33646002)(53416004)(478600001)(16526017)(316002)(16586007)(86362001)(473944003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM4P191MB0001;H:iw-build-2.sondrel.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;AM4P191MB0001;23:a0YWUlkE+9hNZY+xMNXaUxHh4/gELD4t9r0dAVRqg?= =?us-ascii?Q?VZzUKjJ95fL3Rv7RpIJxBpR8N69q9+u3gfaJmSDK8iKBFE1qKo9OnayGdTMG?= =?us-ascii?Q?uPh0qkFlHx+Q7utNJgPEtvOoQolZPZbEgLF2CWYmQ9IjRCc4yGCSEhhwLsZz?= =?us-ascii?Q?YMK0Ud6Nz9bzXPYyjK6J+o7cGp5Bi9g0IqWXMDFV8gr91p+Q3VNFRm+V4dT9?= =?us-ascii?Q?m/3alT1R4Bk0EnNseYNpVOJR/W1lJqlAGq7Nbb9scu+lssPOi3PeyQ8iPQTw?= =?us-ascii?Q?f+HFpewFoB0C67ngd0I5kpr57WIgmoc7lkTPIt1J4ds5lGZBhoHTkIZCF0rH?= =?us-ascii?Q?F+a4xUnCiDt9xctfYOtMBZ23yC7qnlVfbTF4hCEgk7LqGos+kRn0fPNV3USG?= =?us-ascii?Q?E+vuxFAp91XiqrVTMDs1g0a8ahV7CD2pFrwTYxJKF2rysbU64oHkxcjeUhuH?= =?us-ascii?Q?5DML9BT3zsVPy3kkOcRkZ8jJ3q8sOIA0knxoPYuiL3f23QzEFj6edBNJjJbl?= =?us-ascii?Q?PQwW3HWq9aFZX20OdZlGi8u+Z6YU/kfFT8Yg04uokicixnMSboh9QpBLh8IE?= =?us-ascii?Q?ZKv2fIjHa9Zp9rTjufcn4XRVoekt0k0Rm0hiuM+ms+Iv15PkXRYqNF2r7Z7i?= =?us-ascii?Q?NDyzZ1+rP5AUjx5J0JjWYI0ywSsptneP/PZq1eSHpJ+cvVbyER2TeJZpfRMR?= =?us-ascii?Q?2EnJ5BvLNUOe6flJqeQDltfMep2kDvCpsJvHkAMvH2heZE9US+r5ZbMlXD43?= =?us-ascii?Q?FOZnzR19NDblRedJDjMPolRI8sSKohisp1yYYFnpGM0GwnaAqXLskUMnTio9?= =?us-ascii?Q?tNLlQ7IuxX7lwqAT4D08xRtuR+edNkSElZZ80Z4BuLBcUK4DXpQR8sG2Pmb+?= =?us-ascii?Q?jH4eE04OvTNQh26m9Lss33XHhxPv8o56onNMdIo/WsypIv0+D5F03mYxfZRT?= =?us-ascii?Q?zkdTtVMi1oY10VWTrbJFOp7MCq0lRs2pPr9/b8aaushmXIRdopo1BGP9c2u9?= =?us-ascii?Q?qZZq0hYZhvHboRRnU58GBIDSHd7E8O/3bT9gTlUdkQ5+dC7AW7FLWZdy+rL6?= =?us-ascii?Q?aI7DwnQUHrxBU8UrdJ2s7E/hFRKhtDRlwRAJdx939XE18js8wKubT7ubHNWP?= =?us-ascii?Q?2WcDIB7kgk=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM4P191MB0001;6:3Yr+3I2FK0mOy+Fow7dC5XMoUNxTHvWVWtEhTfp1CQUyd4G5CdAFsVl8wruQzkV8hYSG29QG/DlSZhfAEc8sOW/P6jlYV7T41ZpcDXYzCaHdiud9UWBo77AnvQDSm7V7/M+jWGsfXSWIiHT1dMk59m8ORdXaf2R4OkuC5DyWRdQo5xkb02uvvC73xay7zxYh5j2+OT6od9K3Qfuf/gx9OGgjn9/Up0llYrR6qKjSzqkH54dOl+C51kQZPsZ9OJkgmAEMk+xt6UbAgCraROYHaajpks5Ra6hCJk3yNIU8Sh1JHlz0D0ceEErowO2HCOtg+a3xOcvHcuMH1LiYzTefqg==;5:5TrNAp+6pn7rvhuL3jnNW6aPPvMAOs59F3Ix1pxLvGyg6EoLWF0Ba36cXkc6MYfdJ6/j0CXzfh4UH6jhgxCnbk/8riGfsVPI6vnOUUuUcZUa7bt9eMn3u1nt4aMJhdrpzPpn7cSYuV5W/B00qWYIqw==;24:H7QT+PwrZ8hD81wXXCFRPafPMm5Tz6OIJhPxaCSeEq/94AjA0gv013ym2WMlSD+2gwu38KsgT+dh/pXrHskjs9i6S2JB52bg6UUYlMfCt7c=;7:3c8OBplxCB1pTFa+FdELIngyLXA3+2TKK1Gjk1wHJHLmnIPE/+mjRPFoUf7CsvtCmW8DxqLDp0SfJ7wBBgsZdbJZvDW0AbVGhcR0ojbOxPaPPc2Xbmc3u/cWxN05hHIBCDMv3IkUbGVOS5F65BV9QOdO6D3FeutHUeuxMua9mxAdwFPPg24YDdr/21NXy420RIcBwMUmiz+YKs6DO7qG5pS8pgIghGgQLFTG0Il+8tg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: sondrel.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2017 09:56:15.3970 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4faa3872-698e-4896-80ec-148b916cb1ba X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4P191MB0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Set all sys wake polarities to active high during initial setup. The default is active low, which currently causes the 'flow_type' passed into the set_type function to be effectively inverted. Signed-off-by: Ed Blake --- drivers/irqchip/irq-imgpdc.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-imgpdc.c b/drivers/irqchip/irq-imgpdc.c index 22d8f8a..d1bcfef 100644 --- a/drivers/irqchip/irq-imgpdc.c +++ b/drivers/irqchip/irq-imgpdc.c @@ -49,6 +49,8 @@ #define PDC_IRQ_ROUTE_EXT_EN_WD 0x00000004 #define PDC_IRQ_ROUTE_EXT_EN_IR 0x00000002 #define PDC_IRQ_ROUTE_EXT_EN_RTC 0x00000001 +#define PDC_SYS_WAKE_POL 0x00000020 +#define PDC_SYS_WAKE_POL_SHIFT 5 #define PDC_SYS_WAKE_RESET 0x00000010 #define PDC_SYS_WAKE_INT_MODE 0x0000000e #define PDC_SYS_WAKE_INT_MODE_SHIFT 1 @@ -63,6 +65,9 @@ #define PDC_SYS_WAKE_INT_CHANGE 0x6 #define PDC_SYS_WAKE_INT_NONE 0x4 +#define PDC_SYS_WAKE_ACTIVE_LOW 0x0 +#define PDC_SYS_WAKE_ACTIVE_HIGH 0x1 + /** * struct pdc_intc_priv - private pdc interrupt data. * @nr_perips: Number of peripheral interrupt signals. @@ -335,8 +340,9 @@ static void pdc_intc_setup(struct pdc_intc_priv *priv) for (i = 0; i < priv->nr_syswakes; ++i) { /* set the IRQ mode to none */ soc_sys_wake_regoff = PDC_SYS_WAKE_BASE + i*PDC_SYS_WAKE_STRIDE; - soc_sys_wake = PDC_SYS_WAKE_INT_NONE - << PDC_SYS_WAKE_INT_MODE_SHIFT; + soc_sys_wake = + PDC_SYS_WAKE_ACTIVE_HIGH << PDC_SYS_WAKE_POL_SHIFT | + PDC_SYS_WAKE_INT_NONE << PDC_SYS_WAKE_INT_MODE_SHIFT; pdc_write(priv, soc_sys_wake_regoff, soc_sys_wake); } } -- 1.9.1