From: Jin Yao <yao.jin@linux.intel.com>
To: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com
Cc: Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com,
Jin Yao <yao.jin@linux.intel.com>
Subject: [PATCH v4 5/6] perf report: support time percent and multiple time ranges
Date: Tue, 3 Oct 2017 22:22:37 +0800 [thread overview]
Message-ID: <1507040558-20344-6-git-send-email-yao.jin@linux.intel.com> (raw)
In-Reply-To: <1507040558-20344-1-git-send-email-yao.jin@linux.intel.com>
perf report has a --time option to limit the time range of output.
It only supports absolute time.
Now this option is extended to support multiple time ranges and
support the percent of time.
For example:
1. Select the first and second 10% time slices
perf report --time 10%/1,10%/2
2. Select from 0% to 10% and 30% to 40% slices
perf report --time 0%-10%,30%-40%
Change log:
-----------
v4: Remove perf_time__skip_sample, only uses perf_time__ranges_skip_sample
v3: Since the definitions of first_sample_time/last_sample_time
are moved from perf_session to perf_evlist so change the
related code.
Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
---
tools/perf/Documentation/perf-report.txt | 16 ++++++++++++++++
tools/perf/builtin-report.c | 28 ++++++++++++++++++++++++----
2 files changed, 40 insertions(+), 4 deletions(-)
diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt
index 383a98d..3a0975c 100644
--- a/tools/perf/Documentation/perf-report.txt
+++ b/tools/perf/Documentation/perf-report.txt
@@ -402,6 +402,22 @@ OPTIONS
stop time is not given (i.e, time string is 'x.y,') then analysis goes
to end of file.
+ Also support time percent with multipe time range. Time string is
+ 'a%/n,b%/m,...' or 'a%-b%,c%-%d,...'. The maximum number of slices is 10.
+
+ For example:
+ Select the second 10% time slice
+ perf report --time 10%/2
+
+ Select from 0% to 10% time slice
+ perf report --time 0%-10%
+
+ Select the first and second 10% time slices
+ perf report --time 10%/1,10%/2
+
+ Select from 0% to 10% and 30% to 40% slices
+ perf report --time 0%-10%,30%-40%
+
--itrace::
Options for decoding instruction tracing data. The options are:
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index f9dff65..ab7ab25 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -51,6 +51,8 @@
#include <sys/stat.h>
#include <unistd.h>
+#define PTIME_RANGE_MAX 10
+
struct report {
struct perf_tool tool;
struct perf_session *session;
@@ -68,7 +70,8 @@ struct report {
const char *cpu_list;
const char *symbol_filter_str;
const char *time_str;
- struct perf_time_interval ptime;
+ struct perf_time_interval ptime_range[PTIME_RANGE_MAX];
+ int range_num;
float min_percent;
u64 nr_entries;
u64 queue_size;
@@ -185,8 +188,10 @@ static int process_sample_event(struct perf_tool *tool,
};
int ret = 0;
- if (perf_time__skip_sample(&rep->ptime, sample->time))
+ if (perf_time__ranges_skip_sample(rep->ptime_range, rep->range_num,
+ sample->time)) {
return 0;
+ }
if (machine__resolve(machine, &al, sample) < 0) {
pr_debug("problem processing %d event, skipping it.\n",
@@ -1073,8 +1078,23 @@ int cmd_report(int argc, const char **argv)
if (symbol__init(&session->header.env) < 0)
goto error;
- if (perf_time__parse_str(&report.ptime, report.time_str) != 0) {
- pr_err("Invalid time string\n");
+ if (perf_time__parse_str(report.ptime_range, report.time_str) != 0) {
+ report.range_num = perf_time__percent_parse_str(
+ report.ptime_range, PTIME_RANGE_MAX,
+ report.time_str,
+ session->evlist->first_sample_time,
+ session->evlist->last_sample_time);
+
+ if (report.range_num < 0) {
+ pr_err("Invalid time string\n");
+ return -EINVAL;
+ }
+ } else {
+ report.range_num = 1;
+ }
+
+ if (report.range_num > 0 && perf_data_file__is_pipe(session->file)) {
+ pr_err("Time percent range is not supported in pipe\n");
return -EINVAL;
}
--
2.7.4
next prev parent reply other threads:[~2017-10-03 6:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 14:22 [PATCH v4 0/6] perf report/script: Support percent and multiple range in --time option Jin Yao
2017-10-03 14:22 ` [PATCH v4 1/6] perf header: Record first sample time and last sample time in perf file header Jin Yao
2017-10-19 20:17 ` Arnaldo Carvalho de Melo
2017-10-03 14:22 ` [PATCH v4 2/6] perf record: Get the first sample time and last sample time Jin Yao
2017-10-19 20:21 ` Arnaldo Carvalho de Melo
2017-10-19 20:25 ` Arnaldo Carvalho de Melo
2017-10-19 22:49 ` Jin, Yao
2017-10-03 14:22 ` [PATCH v4 3/6] perf util: Create function to parse time percent Jin Yao
2017-10-03 14:22 ` [PATCH v4 4/6] perf util: Create function to perform multiple time range checking Jin Yao
2017-10-03 14:22 ` Jin Yao [this message]
2017-10-03 14:22 ` [PATCH v4 6/6] perf script: support time percent and multiple time ranges Jin Yao
2017-10-05 8:50 ` [PATCH v4 0/6] perf report/script: Support percent and multiple range in --time option Jiri Olsa
2017-10-18 7:19 ` Jin, Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507040558-20344-6-git-send-email-yao.jin@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox