From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751469AbdJCUCa (ORCPT ); Tue, 3 Oct 2017 16:02:30 -0400 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:48737 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750812AbdJCUC1 (ORCPT ); Tue, 3 Oct 2017 16:02:27 -0400 X-IronPort-AV: E=Sophos;i="5.42,475,1500912000"; d="scan'208";a="55880906" From: Bart Van Assche To: "pavel@ucw.cz" , "darrick.wong@oracle.com" , "viro@zeniv.linux.org.uk" , "ming.lei@redhat.com" , "rjw@rjwysocki.net" , "mcgrof@kernel.org" , "linux-fsdevel@vger.kernel.org" , "jikos@kernel.org" , "len.brown@intel.com" , "tytso@mit.edu" CC: "boris.ostrovsky@oracle.com" , "ONeukum@suse.com" , "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "nborisov@suse.com" , "oleg.b.antonyan@gmail.com" , "linux-pm@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "jgross@suse.com" , "martin.petersen@oracle.com" , "oleksandr@natalenko.name" , "todd.e.brandt@linux.intel.com" , "jack@suse.cz" Subject: Re: [RFC 2/5] fs: freeze on suspend and thaw on resume Thread-Topic: [RFC 2/5] fs: freeze on suspend and thaw on resume Thread-Index: AQHTPHjkSs3/4WHyk0Kb3HA1qJjt/KLSjBmA Date: Tue, 3 Oct 2017 20:02:22 +0000 Message-ID: <1507060941.2567.6.camel@wdc.com> References: <20171003185313.1017-1-mcgrof@kernel.org> <20171003185313.1017-3-mcgrof@kernel.org> In-Reply-To: <20171003185313.1017-3-mcgrof@kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [63.163.107.100] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1535;20:EmXXj7bDIBOLrBU2paWjYBdHBopOEYzgXsBfBZ4bhRQ6oHsQp5Rt3MuVROkm2zkTdwmm4VCxZgi0zYIWflLEgFf7c7fXVlsayUHWXrFPSHsh7RDzO7agZGeNsuB6JxoNyOPg3v2sLkKAzwfWirDLrfI8o9++TlBoDHQ5ZVcfAQk= x-ms-office365-filtering-correlation-id: 15ed25b8-8ae4-4cce-756f-08d50a99a902 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:CY1PR0401MB1535; x-ms-traffictypediagnostic: CY1PR0401MB1535: wdcipoutbound: EOP-TRUE x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(20161123564025)(20161123562025)(20161123558100)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR0401MB1535;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR0401MB1535; x-forefront-prvs: 044968D9E1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(376002)(346002)(51444003)(189002)(377424004)(24454002)(52314003)(199003)(5660300001)(4326008)(103116003)(3280700002)(8936002)(2201001)(66066001)(33646002)(77096006)(2906002)(305945005)(8676002)(2950100002)(81166006)(81156014)(68736007)(3660700001)(7736002)(106356001)(6486002)(229853002)(25786009)(6436002)(6246003)(105586002)(6506006)(7416002)(86362001)(53936002)(316002)(39060400002)(76176999)(97736004)(99286003)(36756003)(54906003)(110136005)(101416001)(6116002)(2501003)(102836003)(7520500002)(2900100001)(189998001)(54356999)(478600001)(3846002)(14454004)(6512007)(50986999)(72206003)(2171002)(921003)(1121003);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1535;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <5E9A27AD0F70F64C983B9FEC98B8D12F@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2017 20:02:22.3484 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1535 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v93K2YRa019400 On Tue, 2017-10-03 at 11:53 -0700, Luis R. Rodriguez wrote: > +static bool super_allows_freeze(struct super_block *sb) > +{ > + return !!(sb->s_type->fs_flags & FS_FREEZE_ON_SUSPEND); > +} A minor comment: if "!!" would be left out the compiler will perform the conversion from int to bool implicitly so I propose to leave out the "!!" and parentheses. Anyway, I agree with the approach of this patch and I think that freezing filesystems before processes are frozen would be a big step forward. Bart.