From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751667AbdJCUWH (ORCPT ); Tue, 3 Oct 2017 16:22:07 -0400 Received: from esa1.hgst.iphmx.com ([68.232.141.245]:41852 "EHLO esa1.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751514AbdJCUWE (ORCPT ); Tue, 3 Oct 2017 16:22:04 -0400 X-IronPort-AV: E=Sophos;i="5.42,475,1500912000"; d="scan'208";a="158559608" From: Bart Van Assche To: "jikos@kernel.org" CC: "boris.ostrovsky@oracle.com" , "ONeukum@suse.com" , "linux-block@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "nborisov@suse.com" , "oleg.b.antonyan@gmail.com" , "linux-pm@vger.kernel.org" , "linux-xfs@vger.kernel.org" , "pavel@ucw.cz" , "darrick.wong@oracle.com" , "viro@zeniv.linux.org.uk" , "ming.lei@redhat.com" , "rjw@rjwysocki.net" , "jgross@suse.com" , "oleksandr@natalenko.name" , "todd.e.brandt@linux.intel.com" , "martin.petersen@oracle.com" , "linux-fsdevel@vger.kernel.org" , "mcgrof@kernel.org" , "len.brown@intel.com" , "tytso@mit.edu" , "jack@suse.cz" Subject: Re: [RFC 5/5] pm: remove kernel thread freezing Thread-Topic: [RFC 5/5] pm: remove kernel thread freezing Thread-Index: AQHTPHjmObYS0BO+2Eu+Ihz8qcgUbKLSjzGAgAABAACAAAFPgA== Date: Tue, 3 Oct 2017 20:21:42 +0000 Message-ID: <1507062101.2567.16.camel@wdc.com> References: <20171003185313.1017-1-mcgrof@kernel.org> <20171003185313.1017-6-mcgrof@kernel.org> <1507061605.2567.13.camel@wdc.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [63.163.107.100] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1534;20:iPtD0fviksO3DnOiDVvr6g84TZ49DKt7R9V+JsiCZHM0urq44dMY0q45K6Y5DDGrFPLM4shYz3F3T3ZLfVybYi+MWl8B9jOvIG7kWl769l7mtw65T6ptmsaTqLhEN7JmLYieVBLVZG/qBWOiC10zH5D7DYY243m+gX4vh9Ooz3c= x-ms-office365-filtering-correlation-id: c042a8d8-80e6-4d6c-d345-08d50a9c5c46 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:CY1PR0401MB1534; x-ms-traffictypediagnostic: CY1PR0401MB1534: wdcipoutbound: EOP-TRUE x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123562025)(20161123558100)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR0401MB1534;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR0401MB1534; x-forefront-prvs: 044968D9E1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(376002)(346002)(39860400002)(24454002)(199003)(377424004)(189002)(2950100002)(105586002)(106356001)(77096006)(2900100001)(8676002)(1730700003)(2501003)(3846002)(102836003)(6116002)(86362001)(93886005)(33646002)(25786009)(2351001)(8936002)(6486002)(229853002)(36756003)(81166006)(6436002)(6916009)(97736004)(6246003)(7736002)(6506006)(6306002)(478600001)(305945005)(53936002)(2906002)(316002)(3660700001)(6512007)(72206003)(81156014)(4326008)(68736007)(189998001)(3280700002)(39060400002)(103116003)(54906003)(101416001)(99286003)(66066001)(50986999)(7416002)(76176999)(54356999)(14454004)(5640700003)(5660300001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1534;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <51FF403CC54C1741870215A58DB50BC3@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2017 20:21:42.0708 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1534 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v93KMCc1019662 On Tue, 2017-10-03 at 22:17 +0200, Jiri Kosina wrote: > On Tue, 3 Oct 2017, Bart Van Assche wrote: > > What about the many drivers outside filesystems that use the > > set_freezable() / try_to_freeze() / wait_event_freezable() API? > > Many/most of them are just completely bogus and pointless. I've killed a > lot of those in the past, but the copy/paste programming is just too > strong enemy to fight against. If just a single driver would use that API to prevent that I/O occurs while processes are frozen then this patch will break that driver. I would like to know your opinion about the following patch in particular: "[PATCH v4 1/7] md: Make md resync and reshape threads freezable" (https://www.spinics.net/lists/linux-block/msg17854.html). Thanks, Bart.