From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751557AbdJDKdY (ORCPT ); Wed, 4 Oct 2017 06:33:24 -0400 Received: from victor.provo.novell.com ([137.65.250.26]:56656 "EHLO prv3-mh.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751318AbdJDKdX (ORCPT ); Wed, 4 Oct 2017 06:33:23 -0400 Message-ID: <1507113192.22324.1.camel@suse.com> Subject: Re: [PATCH 1/2] block: genhd: add device_add_disk_with_groups From: Martin Wilck To: Christoph Hellwig Cc: Jens Axboe , Johannes Thumshirn , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Hannes Reinecke , linux-nvme@lists.infradead.org Date: Wed, 04 Oct 2017 12:33:12 +0200 In-Reply-To: <20171001080003.GD11554@lst.de> References: <20170928193637.24707-1-mwilck@suse.com> <20171001080003.GD11554@lst.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.0 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2017-10-01 at 10:00 +0200, Christoph Hellwig wrote: > While this looks okay-ish to me I really don't want people confused > with three variants of add_disk, we really need to consolidate > our helpers there a bit.. > Can you give me a hint what you'd like to see? Martin -- Dr. Martin Wilck , Tel. +49 (0)911 74053 2107 SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)