From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752083AbdJDLM4 (ORCPT ); Wed, 4 Oct 2017 07:12:56 -0400 Received: from smtprelay0186.hostedemail.com ([216.40.44.186]:45738 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751474AbdJDLMx (ORCPT ); Wed, 4 Oct 2017 07:12:53 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1381:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3870:3873:4321:5007:6691:7903:10004:10400:10848:11026:11232:11473:11657:11658:11783:11914:12043:12048:12296:12740:12895:13069:13311:13357:13439:13894:14181:14659:14721:21080:21434:21451:21627:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: coal28_5323c2919d643 X-Filterd-Recvd-Size: 1828 Message-ID: <1507115569.4434.1.camel@perches.com> Subject: Re: [PATCH] Staging: rtl8723bs: Externs should be avoided in .C file From: Joe Perches To: Srinivasan Shanmugam , gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Wed, 04 Oct 2017 04:12:49 -0700 In-Reply-To: <1507107600-2730-1-git-send-email-srinivasan.rns@gmail.com> References: <1507107600-2730-1-git-send-email-srinivasan.rns@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-10-04 at 11:00 +0200, Srinivasan Shanmugam wrote: > This patch fixes the following checkpatch.pl warning. > WARNING: externs should be avoided in .c files Nope. > diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c [] > @@ -17,12 +17,6 @@ > #include > #include > > -extern unsigned char RTW_WPA_OUI[]; > -extern unsigned char WMM_OUI[]; > -extern unsigned char WPS_OUI[]; > -extern unsigned char P2P_OUI[]; > -extern unsigned char WFD_OUT[]; > - > void init_mlme_ap_info(struct adapter *padapter) > { > struct mlme_priv *pmlmepriv = &(padapter->mlmepriv); Please compile any files modified by your proposed changes _before_ you submit them. For instance: $ git grep -w RTW_WPA_OUI drivers/staging/rtl8723bs/core/rtw_ap.c drivers/staging/rtl8723bs/core/rtw_ap.c:extern unsigned char RTW_WPA_OUI[]; drivers/staging/rtl8723bs/core/rtw_ap.c:        if (!memcmp(RTW_WPA_OUI, oui, 4))