From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751846AbdJDL1G (ORCPT ); Wed, 4 Oct 2017 07:27:06 -0400 Received: from mail-db5eur01on0081.outbound.protection.outlook.com ([104.47.2.81]:52096 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751336AbdJDL1E (ORCPT ); Wed, 4 Oct 2017 07:27:04 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pawel.Moll@arm.com; Message-ID: <1507116418.3164.97.camel@arm.com> Subject: Re: [PATCH v2 1/2] bus: arm-ccn: Fix use of smp_processor_id() in preemptible context From: Pawel Moll To: Marc Zyngier , Lorenzo Pieralisi , Suzuki Poulose , Mark Rutland Cc: "linux-kernel@vger.kernel.org" Date: Wed, 04 Oct 2017 12:26:58 +0100 In-Reply-To: <20171003171413.18592-2-marc.zyngier@arm.com> References: <20171003171413.18592-1-marc.zyngier@arm.com> <20171003171413.18592-2-marc.zyngier@arm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 Mime-Version: 1.0 X-Originating-IP: [217.140.96.140] X-ClientProxiedBy: VI1PR0701CA0039.eurprd07.prod.outlook.com (2603:10a6:800:90::25) To DB6PR08MB2677.eurprd08.prod.outlook.com (2603:10a6:6:25::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0a2b1130-e611-4d3f-b7b1-08d50b1ad55d X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:DB6PR08MB2677; X-Microsoft-Exchange-Diagnostics: 1;DB6PR08MB2677;3:gpniWJ2ZsF09JEkBoTGnZL8FNRKNvX0/BJwNnG6GcyrhrIrrzbHNSn/bJ6fEZVFJL7EqJQoO6q5ikoJC/no6cuLsE57Vx3jAH32GhiN/B5fIu2OLmNQXD+G+o48rwz5bsoLyPU0MJSEloNva0W1J25xOwaoWGbYYowLqfqr4MUY9JPBbwBCk9Ad/dApSIkrPaczD1F+YrGx9qOQftSiy5CxFgc75C1YxpprImz9rXSQ/U1EddDHENNHht1WOwiHH;25:GleOAiz8/U4lbxt5sUJYCml+rd+8uw18MwLkDr3zJaplCRQSgKzxSZ3J84wYIqRrBlbB0S8ZIIeu1gSUx/bvBm30zeTRPz3QF0fvD5dmj/MmC4BnPbiPmABEQi/kbcF2iIihVw9cIUG/wrKSsJI/syO7/6Y4F4k+TL78nswcApGRJGIJ5LzJO+4Ou2EjlqyxCvJUctEe5U1Uf8qnE12+SuvSUAgOUP2Oj6hpaMCkHdfez554VDmBzumWGvkXkShbbYQX3r94he1NBJobrRHifNwy4RJRK0zRqNUfHoVFX8L2kiTWbImwp52WeMiZzI6Tz5qXy+S/c9h/KxzoXwdZZQ==;31:TY/84r6l29W5xnCVnEeH6kZvKsra8R0yeHRLcKDbDn628jPdcTvzHeG4nxemU0V4vbRc4mPou3luSdPi5w5SvBp45hCqqN/xanrQAWRVk3dSatMbUZ/zANxEBddR/XxsOUuikkvz48HWWuuEVxoUEJoTA2FCsk/R8+Q1M+H6MwcYXqClRxE0ryHF7YASJ4aqBc3A7/3eirbG2lP+K5Lix+Q9VDhghyfD1Li+HTosySM= X-MS-TrafficTypeDiagnostic: DB6PR08MB2677: X-Microsoft-Exchange-Diagnostics: 1;DB6PR08MB2677;20:aB57b2aPnUtviJ1ohV63XavCNui3Ts2ZyQEAzLq03lQbx+uDwYCWP+AIZO7+SZVhz6HtpOQ0+j8a7EtPorZ4xw7KrPTXjHJrpH0fnK915IOf0hdHlWYlVVnAqGFr+aojijjiwtKsDVX4k6dotzkRJLJi9+jdDaoAToy5YzgdsOfKkcMaGvLgZGVViBNExZ4CsQqLsnSHEjup17XUa2o1s9xEBSTdFuW47WNS2ymOgc4444KoKZw08sweQzBo8KBZIJidFa3/9oB5plUErQz96q+8KQCtCkOtnVLH0VcqWaU3cfQGvYfAkx/KNZUpHIsIsQcHO1AoQQb03nnP9+hqb4xMzFrAcoCxuIToklNiouQjkMJHBBaVhWvf6qlhMnYWXylWBSAOt4AHs2w5Fyt1B/Ktnm02f2bwK3oS1+IuSgwQELHhGNQmPMk1aRQkSfEZQ2ZemNrC543Y/vvwI6xWVKVwMHk/NQ7WNGlUMh3mud/Or7Hv3YZO8V9htw83IvYp;4:7WZ3MapNhhMHBaKJQA3Nn9rI5zdPKyXcLzJCmra2gz23bAFhwKu8eTUzcbU4YXq2wHj2Ek/V5KDt2ReIaTd+2NGZkAFjDdiNKSL7WlBmy+k44FJ55wnx4jopgpLYoLYOZ9zjuXk59GPm+q5HlSi747Lrwb2Muc4znjCYP+cpegdbgEDsaVCN6v0YXeEjKd1+xMc3KD+mQ0KRnZvWVY1Q7OZetKN+gIy6DSjKY1vwwGlReGh2wpGhs8VUNH5KLDrMmMd9WidaWocO8CvOo8idNeaIXMN63hBaUTnY6aHVvSM= X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(6055026)(6041248)(20161123560025)(20161123562025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DB6PR08MB2677;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DB6PR08MB2677; X-Forefront-PRVS: 0450A714CB X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(376002)(346002)(39860400002)(189002)(377424004)(199003)(24454002)(40434004)(50226002)(68736007)(5820100001)(72206003)(2906002)(2950100002)(6486002)(33646002)(229853002)(5660300001)(47776003)(478600001)(66066001)(5890100001)(25786009)(106356001)(23676002)(105586002)(50986999)(103116003)(101416001)(50466002)(316002)(110136005)(6666003)(81156014)(6636002)(4326008)(8676002)(305945005)(189998001)(7736002)(97736004)(86362001)(8746002)(81166006)(8936002)(53936002)(6496005)(6246003)(16526018)(6116002)(3846002)(36756003)(76176999)(99106002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR08MB2677;H:hornet;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjZQUjA4TUIyNjc3OzIzOktrUkl6NmRpSGlGVG8wQXZZNTJ2M0ZhWUdP?= =?utf-8?B?KzlrNDE0R1N0L3pGQkk0Q1R5YjRUcHBOVkQvRzZ6TE9QSlJKUml2Mnpuck92?= =?utf-8?B?Mm53VGhSZG5VY3VsRXZzUXVXMzd3Y2JYSmpPMS9qVDhNOGlCbEhjcEZtbXdq?= =?utf-8?B?cWpZTmgxZE4zdjlWUXoxeEtGamNVV281VlhBZjZGd2s5ZDVtdlZiYkV4dVht?= =?utf-8?B?QllYYWUwNHZvUHpBcitCWm5yM2p5WmM1MmJKdWg2TlhxYUpieWkwUm1IeVBS?= =?utf-8?B?QmRsWm1OeGV1MElJU3RQRi9DTjAvUU8vbDh1S2tockx1ejY5NEVCZEoxUzRq?= =?utf-8?B?ZGVBM29WMG90NlhOL0MxeEJPV1VzRW9QYkMzUnY1M1M5alJCSUpkMjk3c2JV?= =?utf-8?B?NHJaNmJqQlU0U2tKMVR4WmVIeThrS2RkbzBpOFhzQ3FlTWdNWVY5UVlOaVUw?= =?utf-8?B?RDhDTjZWRlR5TnE5ci9JM0RIVThHMmhhYkVXWmxPTFJqWXA0a29EZUJzQUxi?= =?utf-8?B?UjlNek9jb2hOYmNtaTVsQ3Zta2Rod2Nrbk9JeGJNVHJDR0RxeVRTMFgxd0dk?= =?utf-8?B?T2oyS0VKSkl1UVg1V24zbStCSWZPZHJiU3pPclpTbWRSRDNhUmhSZHNzTGtU?= =?utf-8?B?WTNKZlhTTnVqMkxwWm5MYnNoK051WjU4UWR2NkFMTzJNNlZmcDlGYk1UUXQ5?= =?utf-8?B?NFNJWERleTU5c21BUzlubDJreEFySlhnOGlmMnh6ZnBWaXBNWkEvWVNvZXhW?= =?utf-8?B?bnppcHVienExYVI0QWlqYWV4UEkzaEdTZzJJVG44eG96L1kxbUdHQ0JiMG5r?= =?utf-8?B?cDhqUStNWTd3UkhNbEJBVTFtb3pWOGdsNmRMMlBqT2JzQnVhN2JuaUlBQ2Fx?= =?utf-8?B?RmZUMW5wQUlBbHBKT1N4Yld1ci93R085OXhNWUV3WkJuZ25ESk1zRkNvdXYy?= =?utf-8?B?RHJOYkJtbm5WYnk2S3gxRVVLR3B2YVJFY0llQXNlZ25kNE9BUFpsUlFrWitW?= =?utf-8?B?dWJSUkd5NFREYlZFVjVSbWc0SXUrc2dQaHNFL1lXaE5yYVdzVk1mYUluS1Vi?= =?utf-8?B?MDdrSDNUUTlJQUFYSHY3M3d4TlMxbTQrd0dsempLTmNyTGlYd2J2MGxpeHdw?= =?utf-8?B?OGcyaURoZUc2LzBkbEg2NlMzV3BBd2ZSN1hyakc2TmxBamVoeHlVREkzS1Ax?= =?utf-8?B?eGpLT1Vjd0NFOFNOaCtISFAzZnVueVZ5VVdKRWxveEh3RWY1dS8waTZ1b0F4?= =?utf-8?B?NFZ0ZzJTUnhyK3NhOEVYbnBDZmFya0tmTEFTK3lJRUJ3Z1RZREtVUnhLSlZH?= =?utf-8?B?eXBmTWZSM2JZOG1LZ0VYbk5tQUxPNzUxMFR6M21KYzJrNlp6a0FMYUY0dU1C?= =?utf-8?B?MmhvZjBLMmxPWDlJa1N1eWs1dDZqV290OVc1ZVRMbEU0ekd2Q1dEODFPQVBn?= =?utf-8?B?MXJXeGp6bjBMZkxpNHBOMTc3aFgxWElZeVlDLzkrcFdCNDFTN1MyTTNSQ00v?= =?utf-8?B?dTM4MjF2eGhSVzc4dElMaHFCQkpCb0tmUG1NNDF2NkhwaDVQZkxDVHJWTFBQ?= =?utf-8?B?WkpKRmNMMXNoOUpNNDlkcFRvU0YwUFdhQWRhUGpuQ2NSWWxsMnNIKzZhQXFH?= =?utf-8?B?YmhKenFLcWZxUm5CeG1nbUp0VU8veGw3ZjB3dVJVVHZZZTFyQXJCVUIrNW9B?= =?utf-8?B?OEo2VjhZaUZmeDRjRHEzSGVobW5qczJwWGFwYTcxblF3bVVhQkRHeWh5WExt?= =?utf-8?B?Z1NQVHp2ak9RSHhpREwvZz09?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR08MB2677;6:HX3KlqZNrqYRAc7Pkl8hYmuusVDnu6BKz6VmOdAIjkrCZtyp6phZvOEZpgrjt/XRdO7oL/R8ENGfJQ9WfctOpCQnWgPPuo+faK+EAumfb5aYJnAFvPQVJZt2zzGLPQCn3uPfNI2RvL4t+mz+6YBEz/vPlb+vNr+x71CZx8BNxk1bUa4EFmY2MZ4H9yX06V5P52EXojQKksHT/8CK4qT8q4PnL8asaWV27NKLvSHVinJ3K0hKXyXCrFqXlO4/zmXidhweH6/HyvQgeka/+Dv97GkMHQGum8IhPm3nmt14TRIQqREXq7fc6wbsVAt2CJW2TwEh5Qd/clSD+NkarHNLRQ==;5:VAQeMWm7dQhM4i35nes5qBymCUH6auNZ4tqgcwEXGHO+Rli1UdSA333wSwOGvIDWBbtINWl+i5TOWw4t3osjuj7j/L+6P77Q/sMsc6MNZawofpJSSANpVq3jpSiN8/xy0lfwIoFAZgoZheLS2MB7xw==;24:ayMOyXyvQIszYG1wxDXdUPWsK25oQetNT0i0G0D21ynGOTaDKdVRQ1xYJK/gyr5J+LibsejZ6WKc5dx9Bpc2INVuq/RBUg7OPHO4O+XwDb0=;7:1RZxmUmXQFn1gjYneorFEMY/bYT0GyOp+JDIpUvi5DoNMghIp5H5ehBp2CcAfKygPcTIqlZGIN7hYTxO/kxPWtBL8wFDC0YuB2QfQjbxuJ77aXWc9iMLzfb6cqAo5YWng8zG8lWLvt35N4yGsjbs88mXOre3V4VDiV4ivjmgW15WDMhpnIk3dYHk0z1Yy6cw9oiWrUL6UBrUi+EGXzfGLMlkCVHIVw3QE7aSBEnXPIA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2017 11:27:01.4693 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2677 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v94BRBVL017210 On Tue, 2017-10-03 at 18:14 +0100, Marc Zyngier wrote: > Booting a DEBUG_PREEMPT enabled kernel on a CCN-based system > results in the following splat: > > [...] > arm-ccn e8000000.ccn: No access to interrupts, using timer. > BUG: using smp_processor_id() in preemptible [00000000] code: > swapper/0/1 > caller is debug_smp_processor_id+0x1c/0x28 > CPU: 1 PID: 1 Comm: swapper/0 Not tainted 4.13.0 #6111 > Hardware name: AMD Seattle/Seattle, BIOS 17:08:23 Jun 26 2017 > Call trace: > [] dump_backtrace+0x0/0x278 > [] show_stack+0x24/0x30 > [] dump_stack+0x8c/0xb0 > [] check_preemption_disabled+0xfc/0x100 > [] debug_smp_processor_id+0x1c/0x28 > [] arm_ccn_probe+0x358/0x4f0 > [...] > > as we use smp_processor_id() in the wrong context. > > Turn this into a get_cpu()/put_cpu() that extends over the CPU > hotplug > registration, making sure that we don't race against a CPU down > operation. > > Signed-off-by: Marc Zyngier Acked-by: Pawel Moll I assume you'll get this merged yourself? Or do you want me to relay the CCN one (I've got a couple of other small changes to the driver in the queue). Paweł IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.