Re: [PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

Joe Perches
2017-10-04T11:12:56Z

On Wed, 2017-10-04 at 11:00 +0200, Srinivasan Shanmugam wrote:
> This patch fixes the following checkpatch.pl warning.
> WARNING: externs should be avoided in .c files

Nope.

> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
[]
> @@ -17,12 +17,6 @@
> #include <drv_types.h>
> #include <rtw_debug.h>
>
> -extern unsigned char RTW_WPA_OUI[];
> -extern unsigned char WMM_OUI[];
> -extern unsigned char WPS_OUI[];
> -extern unsigned char P2P_OUI[];
> -extern unsigned char WFD_OUT[];
> -
> void init_mlme_ap_info(struct adapter *padapter)
> {
> struct mlme_priv *pmlmepriv = &(padapter->mlmepriv);

Please compile any files modified by your proposed
changes _before_ you
submit them.

For instance:

$ git grep -w RTW_WPA_OUI drivers/staging/rtl8723bs/core/rtw_ap.c
drivers/staging/rtl8723bs/core/rtw_ap.c:extern unsigned char RTW_WPA_OUI[];
drivers/staging/rtl8723bs/core/rtw_ap.c:        if (!memcmp(RTW_WPA_OUI, oui, 4))