Re: [PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

Joe Perches
2017-10-04T12:18:53Z

On Wed, 2017-10-04 at 13:53 +0200, srinivasan wrote:
> Hi Joe,
>
> Thanks for your responses. I have already compiled and the below is the
> logs for the same
>
> Please let me know if am I missing/doing wrong

Your commit message is incomplete.

checkpatch is a guide, but it's not what you should be
describing here.

What whould be in the commit message is that these externs
are unnecessary as they are done via #include of
drivers/staging/rtl8723bs/include/rtw_mlme_ext.h

Also, your patch is not comprehensive.
Please remove the unnecessary externs from all uses:

drivers/staging/rtl8723bs/core/rtw_wlan_util.c:extern unsigned char RTW_WPA_OUI[];

And that file has the odd and conflicting

static unsigned char WPA_TKIP_CIPHER[4] = {0x00, 0x50, 0xf2, 0x02};
[]
extern unsigned char WPA_TKIP_CIPHER[4];

Where the extern is also unnecessary.

cheers, Joe