From: Doug Ledford <dledford@redhat.com>
To: Colin King <colin.king@canonical.com>,
Lijun Ou <oulijun@huawei.com>, Wei Hu <xavier.huwei@huawei.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
linux-rdma@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/hns: return 0 rather than return a garbage status value
Date: Wed, 04 Oct 2017 14:40:43 -0400 [thread overview]
Message-ID: <1507142443.46071.0.camel@redhat.com> (raw)
In-Reply-To: <20170929201308.4704-1-colin.king@canonical.com>
On Fri, 2017-09-29 at 21:13 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> For the case where hr_qp->state == IB_QPS_RESET, an uninitialized
> value in ret is being returned by function hns_roce_v2_query_qp.
> Fix this by setting ret to 0 for this specific return condition.
>
> Detected by CoverityScan, CID#1457203 ("Unitialized scalar variable")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks, applied.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
prev parent reply other threads:[~2017-10-04 18:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 20:13 [PATCH] RDMA/hns: return 0 rather than return a garbage status value Colin King
2017-09-30 7:11 ` Wei Hu (Xavier)
2017-10-04 18:40 ` Doug Ledford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507142443.46071.0.camel@redhat.com \
--to=dledford@redhat.com \
--cc=colin.king@canonical.com \
--cc=hal.rosenstock@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=oulijun@huawei.com \
--cc=sean.hefty@intel.com \
--cc=xavier.huwei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).