From: Scott Wood <swood@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/8] ktest: Use config-bisect.pl in ktest.pl
Date: Wed, 04 Oct 2017 15:24:23 -0500 [thread overview]
Message-ID: <1507148663.2256.26.camel@redhat.com> (raw)
In-Reply-To: <20171004151832.512f774e@gandalf.local.home>
On Wed, 2017-10-04 at 15:18 -0400, Steven Rostedt wrote:
> On Sun, 16 Jul 2017 19:16:30 -0500
> Scott Wood <swood@redhat.com> wrote:
>
> > Reduce code duplication and take advantage of bisection logic
> > improvements by calling config-bisect.pl.
> >
> > The output of make oldconfig is now copied directly to the desired
> > file,
> > rather than doing assign_configs+save_config, in order to preserve
> > the
> > ordering so that diffing the configs at the end will provide useful
> > output.
>
> The reason I never did this, was that I copy ktest.pl all over the
> place :-/ I need it to be a stand alone. I don't copy config-bisect
> around. Not sure how to deal with this.
By "this" I assume you mean using the external config-bisect code,
rather than the part about copying oldconfig output?
The options I can see are to copy both files as a group (possibly making
that easier by renaming config-bisect.pl to ktest-conf-bisect.pl, so you
can "cp tools/testing/ktest/ktest*.pl <dest>"), or just living with code
duplication. In a previous discussion you suggested you preferred that
latter option, though in that case the config bisect logic changes
should ideally be done before the fork.
It should also be noted that ktest.pl only depends on config-bisect.pl
if a config bisect is being performed, so other ktest.pl functions still
work standalone.
-Scott
next prev parent reply other threads:[~2017-10-04 20:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 0:16 [PATCH 1/8] ktest: Clarify config file usage Scott Wood
2017-07-17 0:16 ` [PATCH 2/8] ktest: Set buildonly=1 for CONFIG_BISECT_TYPE=build Scott Wood
2017-07-17 0:16 ` [PATCH 3/8] ktest: Set do_not_reboot=y " Scott Wood
2017-07-17 0:16 ` [PATCH 4/8] ktest: Separate out config bisect logic Scott Wood
2017-07-17 0:16 ` [PATCH 5/8] ktest/config_bisect: Simplify " Scott Wood
2017-07-17 0:16 ` [PATCH 6/8] ktest/config-bisect: Try harder to find a new config Scott Wood
2017-07-17 0:16 ` [PATCH 7/8] ktest: Add simple config-bisect frontend Scott Wood
2017-07-17 0:16 ` [PATCH 8/8] ktest: Use config-bisect.pl in ktest.pl Scott Wood
2017-09-14 21:41 ` Scott Wood
2017-10-04 19:17 ` Steven Rostedt
2017-10-04 19:18 ` Steven Rostedt
2017-10-04 20:24 ` Scott Wood [this message]
2017-10-05 12:50 ` Steven Rostedt
2017-10-05 23:18 ` Scott Wood
2017-10-05 19:43 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507148663.2256.26.camel@redhat.com \
--to=swood@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox