From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751278AbdJEAjl (ORCPT <rfc822;w@1wt.eu>);
        Wed, 4 Oct 2017 20:39:41 -0400
Received: from mga11.intel.com ([192.55.52.93]:40630 "EHLO mga11.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750951AbdJEAjj (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 4 Oct 2017 20:39:39 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.42,479,1500966000"; 
   d="scan'208";a="1227182722"
Message-ID: <1507163979.53049.122.camel@linux.intel.com>
Subject: Re: [PATCH] ACPI / LPIT: Add Low Power Idle Table (LPIT) support
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>, Lv <lv.zheng@intel.com>,
        Len Brown <lenb@kernel.org>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Date: Wed, 04 Oct 2017 17:39:39 -0700
In-Reply-To: <CAJZ5v0j21EMMEQ=BRxzjEeRGaifYSGaxFVzg3TWN63d0EDtJ-g@mail.gmail.com>
References: <1507160613-56852-1-git-send-email-srinivas.pandruvada@linux.intel.com>
         <CAJZ5v0j21EMMEQ=BRxzjEeRGaifYSGaxFVzg3TWN63d0EDtJ-g@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2017-10-05 at 02:10 +0200, Rafael J. Wysocki wrote:
> On Thu, Oct 5, 2017 at 1:43 AM, Srinivas Pandruvada
> <srinivas.pandruvada@linux.intel.com> wrote:
> > 
> > Added functionality to read LPIT table, which provides:
> > 
> > - Sysfs interface to read residency counters via
> > /sys/devices/system/cpu/cpuidle/low_power_idle_cpu_residency_us
> > /sys/devices/system/cpu/cpuidle/low_power_idle_system_residency_us
> > 
> > 

[...]

> > +int lpit_read_residency_count_address(u64 *address)
> > +{
> > +       if (!residency_info_mem.gaddr.address)
> > +               return -EINVAL;
> > +
> > +       *address = residency_info_mem.gaddr.address;
> > +
> > +       return 0;
> > +}
> 
> I don't see users of this.  Are there any?
The user will be pmc_core_driver which will go through platform x86
drivers tree. Also some mei drivers will also need.


[...]

> > 
> > --- /dev/null+++ b/include/acpi/acpi_lpit.h
> > @@ -0,0 +1,34 @@
> > +/*
> > + * acpi_lpit.h - LPIT table processing functions interface
> > + *
> > + * Copyright (C) 2017 Intel Corporation. All rights reserved.
> > + *
> > + * This program is free software; you can redistribute it and/or
> > + * modify it under the terms of the GNU General Public License
> > version
> > + * 2 as published by the Free Software Foundation.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + */
> > +
> > +#ifndef ACPI_LPIT_H
> > +#define ACPI_LPIT_H
> > +
> > +#ifdef CONFIG_ACPI_LPIT
> > +
> > +void acpi_init_lpit(void);
> > +int lpit_read_residency_count_address(u64 *address);
> > +
> > +#else
> > +
> > +static inline void acpi_init_lpit(void) { }
> > +
> > +static inline int lpit_read_residency_count_address(u64 *address)
> > +{
> > +       return -EINVAL;
> > +}
> > +
> > +#endif
> > +#endif
> 
> The above can go into internal.h or sleep.h in drivers/acpi/ IMO.
> There's not need to export it.
The pmc core driver is in drivers/platform/x86. Do you want to include
a local file from there?


Thanks,
Srinivas