From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751415AbdJEDmB (ORCPT ); Wed, 4 Oct 2017 23:42:01 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:56526 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751314AbdJEDl7 (ORCPT ); Wed, 4 Oct 2017 23:41:59 -0400 X-Google-Smtp-Source: AOwi7QCBVxEs8373dqISWXZ6ztq8MvjlKCVsJgyeI16Ib2zl0s+djoC5/PUwxGQSFa5TtLD72zJDQg== Message-ID: <1507174911.4472.3.camel@canonical.com> Subject: Re: [PATCH] USB: serial: qcserial: add Dell DW5818, DW5819 From: Shrirang Bagul To: Johan Hovold Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, =?ISO-8859-1?Q?Bj=F8rn?= Mork Date: Thu, 05 Oct 2017 11:41:51 +0800 In-Reply-To: <20171003133742.GD3404@localhost> References: <20170929043951.8699-1-shrirang.bagul@canonical.com> <20171003133742.GD3404@localhost> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-10-03 at 15:37 +0200, Johan Hovold wrote: > On Fri, Sep 29, 2017 at 12:39:51PM +0800, Shrirang Bagul wrote: > > Dell Wireless 5819/5818 devices are re-branded Sierra Wireless MC74 > > series which will by default boot with vid 0x413c and pid's 0x81cf, > > 0x81d0, 0x81d1,0x81d2. > > > > Signed-off-by: Shrirang Bagul > > Now applied. Thank you. > > Don't you want to add these to qmi_wwan as well? I haven't tested these devices with qmi_wwan. Perhaps a separate patch once it's verified. > > > --- > >  drivers/usb/serial/qcserial.c | 4 ++++ > >  1 file changed, 4 insertions(+) > > > > diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c > > index ebc0beea69d6..eb9928963a53 100644 > > --- a/drivers/usb/serial/qcserial.c > > +++ b/drivers/usb/serial/qcserial.c > > @@ -174,6 +174,10 @@ static const struct usb_device_id id_table[] = { > >   {DEVICE_SWI(0x413c, 0x81b3)}, /* Dell Wireless 5809e Gobi(TM) 4G > > LTE Mobile Broadband Card (rev3) */ > >   {DEVICE_SWI(0x413c, 0x81b5)}, /* Dell Wireless 5811e QDL */ > >   {DEVICE_SWI(0x413c, 0x81b6)}, /* Dell Wireless 5811e QDL */ > > + {DEVICE_SWI(0x413c, 0x81cf)},   /* Dell Wireless 5819 */ > > + {DEVICE_SWI(0x413c, 0x81d0)},   /* Dell Wireless 5819 */ > > + {DEVICE_SWI(0x413c, 0x81d1)},   /* Dell Wireless 5818 */ > > + {DEVICE_SWI(0x413c, 0x81d2)},   /* Dell Wireless 5818 */ > >   > >   /* Huawei devices */ > >   {DEVICE_HWI(0x03f0, 0x581d)}, /* HP lt4112 LTE/HSPA+ Gobi 4G > > Modem (Huawei me906e) */ > > Thanks, > Johan