From: Joe Perches <joe@perches.com>
To: Srinivasan Shanmugam <srinivasan.rns@gmail.com>,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8723bs: Externs should be avoided in .C file
Date: Wed, 04 Oct 2017 21:26:00 -0700 [thread overview]
Message-ID: <1507177560.4434.17.camel@perches.com> (raw)
In-Reply-To: <1507137894-21614-1-git-send-email-srinivasan.rns@gmail.com>
On Wed, 2017-10-04 at 19:24 +0200, Srinivasan Shanmugam wrote:
> Removed warning from 0001-Staging-rtl8723bs-Externs-should-be-avoided-in-.C-fi.patch file after running checkpatch.pl
>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.rns@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_recv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index c0b501e..6b5e48c 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -1226,7 +1226,8 @@ sint validate_recv_ctrl_frame(struct adapter *padapter, union recv_frame *precv_
>
> union recv_frame *recvframe_chk_defrag(struct adapter *padapter, union recv_frame *precv_frame);
>
> -static sint validate_recv_mgnt_frame(struct adapter *padapter, union recv_frame *precv_frame)
> +static int validate_recv_mgnt_frame(struct adapter *padapter,
> + union recv_frame *precv_frame)
> {
> /* struct mlme_priv *pmlmepriv = &adapter->mlmepriv; */
>
This patch does not match the commit message.
This patch changes the return from sint to int and does
some 80 column wrapping.
next prev parent reply other threads:[~2017-10-05 4:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 17:24 [PATCH] Staging: rtl8723bs: Externs should be avoided in .C file Srinivasan Shanmugam
2017-10-05 4:26 ` Joe Perches [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-10-05 11:28 Srinivasan Shanmugam
2017-10-05 13:03 ` Joe Perches
2017-10-04 17:21 Srinivasan Shanmugam
2017-10-18 13:59 ` Greg KH
2017-10-04 14:37 Srinivasan Shanmugam
2017-10-04 9:00 Srinivasan Shanmugam
2017-10-04 11:12 ` Joe Perches
[not found] ` <CAFsTbWc3z5qbZXt5wfWO-0R31aPFO7mgYr6jhP_Tu==GMky2Dw@mail.gmail.com>
2017-10-04 12:18 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507177560.4434.17.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivasan.rns@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox