From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752365AbdJFNdp convert rfc822-to-8bit (ORCPT ); Fri, 6 Oct 2017 09:33:45 -0400 Received: from mout.gmx.net ([212.227.17.22]:62886 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752247AbdJFNdm (ORCPT ); Fri, 6 Oct 2017 09:33:42 -0400 Message-ID: <1507296802.6364.14.camel@gmx.de> Subject: Re: [ANNOUNCE] v4.11.12-rt13 From: Mike Galbraith To: Sebastian Andrzej Siewior Cc: Thomas Gleixner , LKML , linux-rt-users , Anna-Maria Gleixner , Steven Rostedt Date: Fri, 06 Oct 2017 15:33:22 +0200 In-Reply-To: <20171006102820.ou4wpm56ed6m3ewr@linutronix.de> References: <20170905145244.jro4jywfxugmn7eh@linutronix.de> <1507133279.6934.66.camel@gmx.de> <20171005155441.72mjaac5c42rjilf@linutronix.de> <1507256431.6597.16.camel@gmx.de> <20171006102820.ou4wpm56ed6m3ewr@linutronix.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 Mime-Version: 1.0 Content-Transfer-Encoding: 8BIT X-Provags-ID: V03:K0:J7aw3b4SZ+nkZBWkYFzShuJtaMTy2Rwmmc3WjJ/SWm/c7zbPkWn U0vK+TxJKJSuEDkK03LVjxNSh2OHTdRJuec2GF/GttSGL85ypjhpOSOoRBfF5fS3tjaQ34c Vh2gEou8T1T1pM4u7q7TFLpCWOoqvH+wZhi8B+RpeHcn6XhE2mE8dY/IAfs2wOtZGnyLUlX tIMDx+TN1oaL8hNWf79Bg== X-UI-Out-Filterresults: notjunk:1;V01:K0:mU4gXwTwNHw=:pHm58KVPvBVuFy6Q8BPTVM d6A52F3tFAKu0NvuwzqdCiQb7Yi1W1XE+gzU7yF7KJC42LczUgdyNnbiGroUKTICb52ALoe2+ 6WZyTCJT0/aPtKLINQNQpGS0kzwFDgIOctsKiE1+05E8sHgU/ziaJPDrS5QlXhWoP4/shKglz m8isGAX/YwBVWMQBbFQYw1yOiuHPoTMMway3cwJ8Z7s3ziPJyWTij+708A5wlbeCSlzP5jGqb ERr02SCG0k+1fTWiAZrCdSY8n2zDsBW2goJebVJi20L5xYDPV7GZ2ZMNiQooWDYyPhcphL87z Bixd6YevRaBeYwUxbGpm74pJEOzC9tJRWzJwaMATRx9f+gsfCfQ8GmPQbrCGGxeVKg0O7Izvo zCb6o6xE7+lvrgfjbqWGGtbs3kXGZocsoiXpyvQIBm9wIWjwlJMeWsnOH3CS/Mjtz/WRe48HI cK7saXQuc22AFoszr8Bo7rdsqbAF0OR08Sglj8OWCUvvAlQQQW/h5abDLOxcoBczrARYnQOPS xljBqqDGYFV45M+kH7+drpUMrB5GJ4cyZZjXaiz/WAtVONjBWm1QEZc0Z2slrooXvMMJDdiSc VTRPrhC5+8yZXZ9UIHidatKc/IWezuY/ebmr7DdCm079aGudfvMYZ4XYcOjrqNOEYo+HFnpE2 zeyOlomhi/TCovnZ2r9kJn68P2UD7wDiCp12QNZG/PAeKw0X3YXSOcpp6XiYEzaF7gAeQp6oP 6AFiskC+1dZjZv9+r2btKRjb5N57Z/ilOV8FCkdEbfmRaGmRUTjtb9rdl0ZWert2cpAtJzHqs EiCIJzDb9Cmxe5y0kMEyhHbpoOZrJ5kbdAz7+gy7GqPopsXdT8= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-10-06 at 12:28 +0200, Sebastian Andrzej Siewior wrote: > On 2017-10-06 04:20:31 [+0200], Mike Galbraith wrote: > > On Thu, 2017-10-05 at 17:54 +0200, Sebastian Andrzej Siewior wrote: > > > On 2017-10-04 18:07:59 [+0200], Mike Galbraith wrote: > > > > Seems combo-patch induced some ltp posix conformance test grumbling. > > > > > > > > +clock_settime_8_1 ... ... FAILED > > > > +clock_settime_4_2 ... ... FAILED > > > > +clock_settime_speculative_4_3 ... ... FAILED > > > > +timer_settime_5_2 ... ... FAILED > > > > +timer_settime_5_1 ... ... FAILED > > > > +timer_settime_5_3 ... ... FAILED > > > > > > > > rtbox:/root # /usr/local/ltp/conformance/interfaces/clock_settime/clock_settime_8-1.run-test > > > > Ended too late. 1507131910 >> 1507131908 > > > > Test FAILED > > > > rtbox:/root # /usr/local/ltp/conformance/interfaces/clock_settime/clock_settime_4-2.run-test > > > > timer should have expired _immediately_ > > > > rtbox:/root # /usr/local/ltp/conformance/interfaces/clock_settime/speculative/clock_settime_speculative_4-3.run-test > > > > Overrun count =0, not # of repeating timer expirys > > > > FAIL: Caught 0 signals, not 1 > > > > Test FAILED > > > > rtbox:/root # /opt/ltp/conformance/interfaces/timer_settime/timer_settime_5-2.run-test > > > > signal was not sent > > > > > > So the last triggers here, too and I have an idea. > > > > I ran a trace of clock_settime_4-2.run-test, which arms a timer for > > now+9 seconds, then clock_settime to advance 4 seconds past timer > > expiration, which should cause the timer to fire.  Going through > > SyS_clock_settime..retrigger_next_event..lapic_next_deadline does not > > trigger interrupt, but does without the culprit patch applied. > > This seems to fix this. Yup, with this, when we get to clockevents_program_event(), we take the proper if (delta <= 0) path again, and are rewarded with an interrupt. I'll run full ltp again, make sure there are no new failure deltas. > Subject: hrtimer: Update offset for soft bases > From: Anna-Maria Gleixner > Date: Fri, 06 Oct 2017 11:28:38 +0200 > > The offset of the clock bases is done via timekeeping mechanisms. The > offsets of the soft bases has to be considered as well. > > Signed-off-by: Anna-Maria Gleixner > --- > kernel/time/hrtimer.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > --- a/kernel/time/hrtimer.c > +++ b/kernel/time/hrtimer.c > @@ -551,8 +551,14 @@ static inline ktime_t hrtimer_update_bas > ktime_t *offs_boot = &base->clock_base[HRTIMER_BASE_BOOTTIME].offset; > ktime_t *offs_tai = &base->clock_base[HRTIMER_BASE_TAI].offset; > > - return ktime_get_update_offsets_now(&base->clock_was_set_seq, > + ktime_t now = ktime_get_update_offsets_now(&base->clock_was_set_seq, > offs_real, offs_boot, offs_tai); > + > + base->clock_base[HRTIMER_BASE_REALTIME_SOFT].offset = *offs_real; > + base->clock_base[HRTIMER_BASE_BOOTTIME_SOFT].offset = *offs_boot; > + base->clock_base[HRTIMER_BASE_TAI_SOFT].offset = *offs_tai; > + > + return now; > } > > /* > > Sebastian