From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753462AbdJHW07 (ORCPT ); Sun, 8 Oct 2017 18:26:59 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:37092 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751214AbdJHW05 (ORCPT ); Sun, 8 Oct 2017 18:26:57 -0400 X-Google-Smtp-Source: AOwi7QAHJptzI7UEMqa6I3dqvbAfUyGzURgwmrBeHP11thu4SF8FsI5QSMFURgaa9QR2nXVkWUe5qw== From: Christos Gkekas To: Dmitry Torokhov , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Christos Gkekas Subject: [PATCH] Input: synaptics-rmi4: Clean up redundant check Date: Sun, 8 Oct 2017 23:26:51 +0100 Message-Id: <1507501611-16703-1-git-send-email-chris.gekas@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Variable size_presence_reg·is unsigned so checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas --- drivers/input/rmi4/rmi_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c index 4f2bb59..68fcb30 100644 --- a/drivers/input/rmi4/rmi_driver.c +++ b/drivers/input/rmi4/rmi_driver.c @@ -601,7 +601,7 @@ int rmi_read_register_desc(struct rmi_device *d, u16 addr, return ret; ++addr; - if (size_presence_reg < 0 || size_presence_reg > 35) + if (size_presence_reg > 35) return -EIO; memset(buf, 0, sizeof(buf)); -- 2.7.4