From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753608AbdJHW5z (ORCPT ); Sun, 8 Oct 2017 18:57:55 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35588 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751001AbdJHW5y (ORCPT ); Sun, 8 Oct 2017 18:57:54 -0400 X-Google-Smtp-Source: AOwi7QCpqndv6z8ThGoyPdCA4DBGXYJJTTFNiGdK7KPlIG7S227QzmyhkmTZRny37P4JBG5nyxGD3A== From: Christos Gkekas To: Darren Hart , Andy Shevchenko , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Christos Gkekas Subject: [PATCH] intel-oaktrail: Clean up dead code Date: Sun, 8 Oct 2017 23:57:49 +0100 Message-Id: <1507503469-22507-1-git-send-email-chris.gekas@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A couple of macros are unused and need to be removed. Also variable percent is unsigned so checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas --- drivers/platform/x86/intel_oaktrail.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/platform/x86/intel_oaktrail.c b/drivers/platform/x86/intel_oaktrail.c index 5747f63..0614d2b 100644 --- a/drivers/platform/x86/intel_oaktrail.c +++ b/drivers/platform/x86/intel_oaktrail.c @@ -68,12 +68,10 @@ */ #define OT_EC_DEVICE_STATE_ADDRESS 0xD6 -#define OT_EC_CAMERA_MASK (1 << 0) #define OT_EC_BT_MASK (1 << 1) #define OT_EC_GPS_MASK (1 << 2) #define OT_EC_WIFI_MASK (1 << 3) #define OT_EC_WWAN_MASK (1 << 4) -#define OT_EC_TS_MASK (1 << 5) /* * This is the address in EC space and commands used to control LCD backlight: @@ -228,7 +226,7 @@ static int get_backlight_brightness(struct backlight_device *b) static int set_backlight_brightness(struct backlight_device *b) { u8 percent = (u8) b->props.brightness; - if (percent < 0 || percent > OT_EC_BL_BRIGHTNESS_MAX) + if (percent > OT_EC_BL_BRIGHTNESS_MAX) return -EINVAL; ec_write(OT_EC_BL_BRIGHTNESS_ADDRESS, percent); -- 2.7.4