From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754149AbdJIMAq (ORCPT ); Mon, 9 Oct 2017 08:00:46 -0400 Received: from smtprelay0007.hostedemail.com ([216.40.44.7]:51612 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754086AbdJIMAp (ORCPT ); Mon, 9 Oct 2017 08:00:45 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:2899:3138:3139:3140:3141:3142:3351:3622:3865:3867:3870:3872:3873:4250:4321:5007:10004:10400:10848:11026:11473:11658:11914:12296:12740:12760:12895:13019:13069:13095:13311:13357:13439:14659:14721:21080:21433:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: cave71_408a2618a4d00 X-Filterd-Recvd-Size: 1608 Message-ID: <1507550442.3552.2.camel@perches.com> Subject: Re: [PATCH] tty: n_gsm: pr_err() strings should end with newlines From: Joe Perches To: Arvind Yadav , gregkh@linuxfoundation.org, jslaby@suse.com Cc: linux-kernel@vger.kernel.org Date: Mon, 09 Oct 2017 05:00:42 -0700 In-Reply-To: References: Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-10-09 at 17:14 +0530, Arvind Yadav wrote: > pr_err() messages should end with a new-line to avoid other messages > being concatenated. [] > diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c [] > @@ -2788,7 +2788,7 @@ static int gsm_create_network(struct gsm_dlci *dlci, struct gsm_netconfig *nc) > net = alloc_netdev(sizeof(struct gsm_mux_net), netname, > NET_NAME_UNKNOWN, gsm_mux_net_init); > if (!net) { > - pr_err("alloc_netdev failed"); > + pr_err("alloc_netdev failed\n"); > return -ENOMEM; > } > net->mtu = dlci->gsm->mtu; You could just delete the pr_err instead. It's an unnecessary message as there would be a dump_stack() on the kvzalloc() in alloc_netdev() on any OOM failure.