From: Doug Ledford <dledford@redhat.com>
To: Shiraz Saleem <shiraz.saleem@intel.com>,
Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org,
Faisal Latif <faisal.latif@intel.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
linux-rdma@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] RDMA/i40iw: Convert timers to use timer_setup()
Date: Mon, 09 Oct 2017 12:25:24 -0400 [thread overview]
Message-ID: <1507566324.46071.37.camel@redhat.com> (raw)
In-Reply-To: <20171007141255.GA2536@ssaleem-MOBL4.amr.corp.intel.com>
On Sat, 2017-10-07 at 09:12 -0500, Shiraz Saleem wrote:
> Hi Kees,
>
> Sorry, I didnt notice this earlier, but, you made the change only to
> the stats timer
> to use the new timer init APIs. Can you do the same for the cm_timer
> and terminate_timer
> too for i40iw; so that things are consistent?
>
> [ssaleem@linbuild6081 i40iw]$ grep "setup_timer" *
> i40iw_cm.c: setup_timer(&cm_core->tcp_timer, i40iw_cm_timer_tick,
> i40iw_utils.c: setup_timer(&iwqp->terminate_timer,
> i40iw_terminate_timeout,
> i40iw_utils.c: setup_timer(&devstat->stats_timer,
> i40iw_hw_stats_timeout,
Since I took the first patch, this will need to be as an incremental
change.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
next prev parent reply other threads:[~2017-10-09 16:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 0:45 [PATCH] RDMA/i40iw: Convert timers to use timer_setup() Kees Cook
2017-10-06 23:17 ` Shiraz Saleem
2017-10-07 14:12 ` Shiraz Saleem
2017-10-09 16:25 ` Doug Ledford [this message]
2017-10-17 18:37 ` Kees Cook
2017-10-09 16:24 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507566324.46071.37.camel@redhat.com \
--to=dledford@redhat.com \
--cc=faisal.latif@intel.com \
--cc=hal.rosenstock@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
--cc=shiraz.saleem@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).