From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754825AbdJIQZ1 (ORCPT ); Mon, 9 Oct 2017 12:25:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40388 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751676AbdJIQZ0 (ORCPT ); Mon, 9 Oct 2017 12:25:26 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 34305C0587EF Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dledford@redhat.com Message-ID: <1507566324.46071.37.camel@redhat.com> Subject: Re: [PATCH] RDMA/i40iw: Convert timers to use timer_setup() From: Doug Ledford To: Shiraz Saleem , Kees Cook Cc: linux-kernel@vger.kernel.org, Faisal Latif , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org, Thomas Gleixner Date: Mon, 09 Oct 2017 12:25:24 -0400 In-Reply-To: <20171007141255.GA2536@ssaleem-MOBL4.amr.corp.intel.com> References: <20171005004541.GA22645@beast> <20171006231723.GA22568@ssaleem-MOBL4.amr.corp.intel.com> <20171007141255.GA2536@ssaleem-MOBL4.amr.corp.intel.com> Organization: Red Hat, Inc. Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 09 Oct 2017 16:25:26 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2017-10-07 at 09:12 -0500, Shiraz Saleem wrote: > Hi Kees, > > Sorry, I didnt notice this earlier, but, you made the change only to > the stats timer > to use the new timer init APIs. Can you do the same for the cm_timer > and terminate_timer > too for i40iw; so that things are consistent? > > [ssaleem@linbuild6081 i40iw]$ grep "setup_timer" * > i40iw_cm.c: setup_timer(&cm_core->tcp_timer, i40iw_cm_timer_tick, > i40iw_utils.c: setup_timer(&iwqp->terminate_timer, > i40iw_terminate_timeout, > i40iw_utils.c: setup_timer(&devstat->stats_timer, > i40iw_hw_stats_timeout, Since I took the first patch, this will need to be as an incremental change. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD