From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@kernel.org, torvalds@linux-foundation.org,
mark.rutland@arm.com, dhowells@redhat.com,
linux-arch@vger.kernel.org, peterz@infradead.org,
will.deacon@arm.com,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>
Subject: [PATCH RFC tip/core/rcu 09/15] uprobes: Remove now-redundant smp_read_barrier_depends()
Date: Mon, 9 Oct 2017 17:22:43 -0700 [thread overview]
Message-ID: <1507594969-8347-9-git-send-email-paulmck@linux.vnet.ibm.com> (raw)
In-Reply-To: <20171010001951.GA6476@linux.vnet.ibm.com>
Now that READ_ONCE() implies smp_read_barrier_depends(), the
get_xol_area() and get_trampoline_vaddr() no longer need their
smp_read_barrier_depends() calls, which this commit removes.
While we are here, convert the corresponding smp_wmb() to an
smp_store_release().
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
kernel/events/uprobes.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
index 267f6ef91d97..ce6848e46e94 100644
--- a/kernel/events/uprobes.c
+++ b/kernel/events/uprobes.c
@@ -1167,8 +1167,8 @@ static int xol_add_vma(struct mm_struct *mm, struct xol_area *area)
}
ret = 0;
- smp_wmb(); /* pairs with get_xol_area() */
- mm->uprobes_state.xol_area = area;
+ /* pairs with get_xol_area() */
+ smp_store_release(&mm->uprobes_state.xol_area, area); /* ^^^ */
fail:
up_write(&mm->mmap_sem);
@@ -1230,8 +1230,8 @@ static struct xol_area *get_xol_area(void)
if (!mm->uprobes_state.xol_area)
__create_xol_area(0);
- area = mm->uprobes_state.xol_area;
- smp_read_barrier_depends(); /* pairs with wmb in xol_add_vma() */
+ /* Pairs with xol_add_vma() smp_store_release() */
+ area = READ_ONCE(mm->uprobes_state.xol_area); /* ^^^ */
return area;
}
@@ -1528,8 +1528,8 @@ static unsigned long get_trampoline_vaddr(void)
struct xol_area *area;
unsigned long trampoline_vaddr = -1;
- area = current->mm->uprobes_state.xol_area;
- smp_read_barrier_depends();
+ /* Pairs with xol_add_vma() smp_store_release() */
+ area = READ_ONCE(current->mm->uprobes_state.xol_area); /* ^^^ */
if (area)
trampoline_vaddr = area->vaddr;
--
2.5.2
next prev parent reply other threads:[~2017-10-10 0:23 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 0:19 [PATCH RFC tip/core/rcu 0/15] Remove to-be-unneeded smp_read_barrier_depends() Paul E. McKenney
2017-10-10 0:22 ` [PATCH RFC tip/core/rcu 01/15] doc: READ_ONCE() now implies smp_barrier_depends() Paul E. McKenney
2017-10-10 0:22 ` [PATCH RFC tip/core/rcu 02/15] mn10300: READ_ONCE() now implies smp_read_barrier_depends() Paul E. McKenney
2017-10-10 0:22 ` [PATCH RFC tip/core/rcu 03/15] drivers/net/ethernet/qlogic/qed: Fix __qed_spq_block() ordering Paul E. McKenney
2017-10-10 0:22 ` [PATCH RFC tip/core/rcu 04/15] fs/dcache: Use release-acquire for name/length update Paul E. McKenney
2017-10-10 0:22 ` [PATCH RFC tip/core/rcu 05/15] percpu: READ_ONCE() now implies smp_read_barrier_depends() Paul E. McKenney
2017-10-10 14:08 ` Tejun Heo
2017-10-10 15:30 ` Paul E. McKenney
2017-10-10 15:49 ` Tejun Heo
2017-10-10 0:22 ` [PATCH RFC tip/core/rcu 06/15] rcu: Adjust read-side accessor comments for READ_ONCE() Paul E. McKenney
2017-10-10 0:22 ` [PATCH RFC tip/core/rcu 07/15] rtnetlink: Update now-misleading smp_read_barrier_depends() comment Paul E. McKenney
2017-10-10 0:22 ` [PATCH RFC tip/core/rcu 08/15] seqlock: Remove now-redundant smp_read_barrier_depends() Paul E. McKenney
2017-10-10 0:22 ` Paul E. McKenney [this message]
2017-10-10 0:22 ` [PATCH RFC tip/core/rcu 10/15] locking: Remove smp_read_barrier_depends() from queued_spin_lock_slowpath() Paul E. McKenney
2017-10-10 0:22 ` [PATCH RFC tip/core/rcu 11/15] tracepoint: Remove smp_read_barrier_depends() from comment Paul E. McKenney
2017-10-10 0:31 ` Steven Rostedt
2017-10-10 1:12 ` Mathieu Desnoyers
2017-10-10 15:32 ` Paul E. McKenney
2017-10-10 0:22 ` [PATCH RFC tip/core/rcu 12/15] lib/assoc_array: Remove smp_read_barrier_depends() Paul E. McKenney
2017-10-10 8:39 ` Peter Zijlstra
2017-10-10 9:36 ` David Howells
2017-10-10 0:22 ` [PATCH RFC tip/core/rcu 13/15] mm/ksm: Remove now-redundant smp_read_barrier_depends() Paul E. McKenney
2017-10-10 0:22 ` [PATCH RFC tip/core/rcu 14/15] netfilter: " Paul E. McKenney
2017-10-10 8:43 ` Peter Zijlstra
2017-10-10 15:56 ` Paul E. McKenney
2017-10-10 0:22 ` [PATCH RFC tip/core/rcu 15/15] keyring: " Paul E. McKenney
2017-10-10 9:35 ` [PATCH RFC tip/core/rcu 12/15] lib/assoc_array: Remove smp_read_barrier_depends() David Howells
2017-10-10 15:50 ` Paul E. McKenney
2017-10-10 15:54 ` Peter Zijlstra
2017-10-10 16:05 ` Paul E. McKenney
2017-10-11 12:19 ` David Howells
2017-10-11 12:22 ` Will Deacon
2017-10-11 12:54 ` Paul E. McKenney
2017-10-11 14:18 ` Will Deacon
2017-10-11 14:50 ` Paul E. McKenney
2017-10-11 12:58 ` Paul E. McKenney
2017-10-11 15:17 ` David Howells
2017-10-11 15:59 ` Paul E. McKenney
2017-10-11 16:12 ` Peter Zijlstra
2017-10-11 16:24 ` Peter Zijlstra
2017-10-11 16:47 ` Paul E. McKenney
2017-10-11 16:54 ` Peter Zijlstra
2017-10-11 17:06 ` Paul E. McKenney
2017-10-11 17:11 ` Peter Zijlstra
2017-10-11 17:34 ` Paul E. McKenney
2017-10-11 18:43 ` Dmitry Vyukov
2017-10-11 18:56 ` Linus Torvalds
2017-10-11 19:28 ` Paul E. McKenney
2017-10-11 19:59 ` Dmitry Vyukov
2017-10-11 17:14 ` Paul E. McKenney
2017-10-11 17:19 ` Mark Rutland
2017-10-11 16:50 ` Paul E. McKenney
2017-10-11 16:07 ` David Howells
2017-10-11 16:17 ` Peter Zijlstra
2017-10-11 16:19 ` Paul E. McKenney
2017-10-11 15:28 ` David Howells
2017-10-11 16:02 ` Paul E. McKenney
2017-10-10 9:59 ` David Howells
2017-10-10 15:52 ` Paul E. McKenney
2017-10-11 12:21 ` [PATCH RFC tip/core/rcu 0/15] Remove to-be-unneeded smp_read_barrier_depends() David Howells
2017-10-11 12:56 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507594969-8347-9-git-send-email-paulmck@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=dhowells@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).