From: Rik van Riel <riel@surriel.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Gargi Sharma <gs051095@gmail.com>
Cc: linux-kernel@vger.kernel.org, julia.lawall@lip6.fr,
mingo@kernel.org, pasha.tatashin@oracle.com,
ktkhai@virtuozzo.com, oleg@redhat.com, ebiederm@xmission.com,
hch@infradead.org, lkp@intel.com, tony.luck@intel.com
Subject: Re: [PATCH v6 1/2] pid: Replace pid bitmap implementation with IDR API
Date: Wed, 11 Oct 2017 20:54:32 -0400 [thread overview]
Message-ID: <1507769672.21121.192.camel@surriel.com> (raw)
In-Reply-To: <20171011153716.5cd0689bb7030b886b0d62f9@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 1035 bytes --]
On Wed, 2017-10-11 at 15:37 -0700, Andrew Morton wrote:
> On Wed, 11 Oct 2017 18:19:38 -0400 Gargi Sharma <gs051095@gmail.com>
> wrote:
>
> > This patch replaces the current bitmap implemetation for
> > Process ID allocation. Functions that are no longer required,
> > for example, free_pidmap(), alloc_pidmap(), etc. are removed.
> > The rest of the functions are modified to use the IDR API.
> > The change was made to make the PID allocation less complex by
> > replacing custom code with calls to generic API.
>
> I still don't understand the locking. spin_lock_irq(&pidmap_lock) in
> some places, rcu_read_lock() in others.
>
> If the locking is indeed now correct, can we please get it fully
> documented? A comment at the pid_namespace.idr definition site would
> suit.
Would you like me to send a follow-up patch to document the
locking?
Documenting the locking on all the existing code, plus the
new code, seems a little out of scope of an Outreachy
internship...
--
All Rights Reversed.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2017-10-12 0:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 22:19 [PATCH v6 0/2] Replacing PID bitmap implementation with IDR API Gargi Sharma
2017-10-11 22:19 ` [PATCH v6 1/2] pid: Replace pid " Gargi Sharma
2017-10-11 22:28 ` Rik van Riel
2017-10-11 22:37 ` Andrew Morton
2017-10-12 0:54 ` Rik van Riel [this message]
2017-10-12 22:58 ` Andrew Morton
2017-10-13 14:58 ` Oleg Nesterov
2017-10-19 7:30 ` [v6,1/2] " Andrei Vagin
2017-10-19 13:20 ` Gargi Sharma
2017-10-19 16:18 ` Oleg Nesterov
2017-10-20 16:06 ` Gargi Sharma
2017-10-20 17:21 ` Andrei Vagin
2017-10-22 8:05 ` Gargi Sharma
2017-10-23 15:31 ` Oleg Nesterov
2017-10-11 22:19 ` [PATCH v6 2/2] pid: Remove pidhash Gargi Sharma
2017-10-11 22:28 ` Rik van Riel
2017-10-11 22:47 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507769672.21121.192.camel@surriel.com \
--to=riel@surriel.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=gs051095@gmail.com \
--cc=hch@infradead.org \
--cc=julia.lawall@lip6.fr \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=pasha.tatashin@oracle.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox