From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754085AbdJLAy7 (ORCPT ); Wed, 11 Oct 2017 20:54:59 -0400 Received: from shelob.surriel.com ([96.67.55.147]:53845 "EHLO shelob.surriel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752678AbdJLAyy (ORCPT ); Wed, 11 Oct 2017 20:54:54 -0400 Message-ID: <1507769672.21121.192.camel@surriel.com> Subject: Re: [PATCH v6 1/2] pid: Replace pid bitmap implementation with IDR API From: Rik van Riel To: Andrew Morton , Gargi Sharma Cc: linux-kernel@vger.kernel.org, julia.lawall@lip6.fr, mingo@kernel.org, pasha.tatashin@oracle.com, ktkhai@virtuozzo.com, oleg@redhat.com, ebiederm@xmission.com, hch@infradead.org, lkp@intel.com, tony.luck@intel.com Date: Wed, 11 Oct 2017 20:54:32 -0400 In-Reply-To: <20171011153716.5cd0689bb7030b886b0d62f9@linux-foundation.org> References: <1507760379-21662-1-git-send-email-gs051095@gmail.com> <1507760379-21662-2-git-send-email-gs051095@gmail.com> <20171011153716.5cd0689bb7030b886b0d62f9@linux-foundation.org> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-h+gl8f0c8a7k0i/8nHKF" X-Mailer: Evolution 3.22.6 (3.22.6-2.fc25) Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-h+gl8f0c8a7k0i/8nHKF Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2017-10-11 at 15:37 -0700, Andrew Morton wrote: > On Wed, 11 Oct 2017 18:19:38 -0400 Gargi Sharma > wrote: >=20 > > This patch replaces the current bitmap implemetation for > > Process ID allocation. Functions that are no longer required, > > for example, free_pidmap(), alloc_pidmap(), etc. are removed. > > The rest of the functions are modified to use the IDR API. > > The change was made to make the PID allocation less complex by > > replacing custom code with calls to generic API. >=20 > I still don't understand the locking.=C2=A0=C2=A0spin_lock_irq(&pidmap_lo= ck) in > some places, rcu_read_lock() in others. >=20 > If the locking is indeed now correct, can we please get it fully > documented?=C2=A0=C2=A0A comment at the pid_namespace.idr definition site= would > suit. Would you like me to send a follow-up patch to document the locking? Documenting the locking on all the existing code, plus the new code, seems a little out of scope of an Outreachy internship... --=20 All Rights Reversed. --=-h+gl8f0c8a7k0i/8nHKF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAABCAAGBQJZ3r1JAAoJEM553pKExN6D7cIH/RoGXashyXG64kdB2PtBey9B GlKkWamjUNkXTiopSD173KWW6SxLCLygeA3zSIlXXjvakdQJnMzjLs06mPRkvpwk eN8KiyfekJ4UvXnXioSAJ3yK3tc/pJG2RPD+qbIKL/PR/3AZAmcJYgasEtSRmDq9 aNzeuPmRw+hOpD/FfSg91raKCezsoppEMR/fgBH2QWdbsdYlOx/TurzDd65BYZ/4 HYfEf0Z91T9BhkR2A4JTSPQgOpX/5lbLwY3moldbynKTzwu5qfhIxjzLMZwzkdfN xsQpXFNRJUWCkieQ1cL3smRmOFNmaLUg60hTPMWx/BP5gzlFTSsOZzhty68GF2k= =wa61 -----END PGP SIGNATURE----- --=-h+gl8f0c8a7k0i/8nHKF--