From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758458AbdJMPQx (ORCPT ); Fri, 13 Oct 2017 11:16:53 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:37634 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758396AbdJMPQw (ORCPT ); Fri, 13 Oct 2017 11:16:52 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org CF8FE61A49 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=shankerd@codeaurora.org From: Shanker Donthineni To: Marc Zyngier , linux-kernel , linux-arm-kernel Cc: Thomas Gleixner , Jason Cooper , Vikram Sethi , Shanker Donthineni Subject: [PATCH v2] irqchip/gic-v3-its: Fix the incorrect BUG_ON in its_init_vpe_domain() Date: Fri, 13 Oct 2017 10:16:47 -0500 Message-Id: <1507907807-10148-1-git-send-email-shankerd@codeaurora.org> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver probe path hits 'BUG_ON(entries != vpe_proxy.dev->nr_ites)' on systems where it has VLPI capability, doesn't support direct LPI feature and boot with a single CPU. Relax the BUG_ON() condition to fix the issue. Crash log messages on QDF2400 when booting with a single core. ------------[ cut here ]------------ kernel BUG at /v4.14-rc2/kernel/drivers/irqchip/irq-gic-v3-its.c:2854! Internal error: Oops - BUG: 0 [#1] SMP 0.000000] Modules linked in: CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.14.0+ #5 [] its_init+0x310/0x370 [] gic_init_bases+0x18c/0x29c [] gic_acpi_init+0x118/0x234 [] acpi_match_madt+0x44/0x78 [] acpi_table_parse_entries_array+0x11c/0x1e0 [] acpi_table_parse_entries+0x28/0x30 [] acpi_table_parse_madt+0x24/0x2c [] __acpi_probe_device_table+0x80/0xdc [] irqchip_init+0x30/0x38 [] init_IRQ+0xb4/0xe8 [] start_kernel+0x238/0x3a0 Code: 14000011 b9407802 6b15005f 54000040 (d4210000) ---[ end trace 4defdcd9ed65d530 ]--- Signed-off-by: Shanker Donthineni --- Changes since v1: -Added crash log messages to commit text. drivers/irqchip/irq-gic-v3-its.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index 4b598b6..83220f7 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -2921,7 +2921,7 @@ static int its_init_vpe_domain(void) return -ENOMEM; } - BUG_ON(entries != vpe_proxy.dev->nr_ites); + BUG_ON(entries > vpe_proxy.dev->nr_ites); raw_spin_lock_init(&vpe_proxy.lock); vpe_proxy.next_victim = 0; -- Qualcomm Datacenter Technologies, Inc. on behalf of the Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.