From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752337AbdJMQ3t (ORCPT ); Fri, 13 Oct 2017 12:29:49 -0400 Received: from mail-by2nam03on0040.outbound.protection.outlook.com ([104.47.42.40]:22906 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751040AbdJMQ3r (ORCPT ); Fri, 13 Oct 2017 12:29:47 -0400 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=nxp.com; Message-ID: <1507912181.10770.15.camel@nxp.com> Subject: Re: [PATCH RESEND] regulator: rn5t618: add RC5T619 PMIC support From: Leonard Crestez To: Pierre-Hugues Husson , Mark Brown , "Lee Jones" CC: Liam Girdwood , Date: Fri, 13 Oct 2017 19:29:41 +0300 In-Reply-To: <20170827135831.15860-1-phh@phh.me> References: <20170827135831.15860-1-phh@phh.me> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131523857850497358;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.158.2;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(336005)(376002)(346002)(39380400002)(39860400002)(2980300002)(1110001)(1109001)(339900001)(199003)(24454002)(377424004)(189002)(498600001)(77096006)(47776003)(189998001)(50466002)(6246003)(86362001)(2870700001)(8676002)(2906002)(53936002)(104016004)(103116003)(39060400002)(68736007)(4326008)(33646002)(5660300001)(69596002)(97736004)(106466001)(105606002)(2950100002)(356003)(110136005)(23676002)(316002)(54906003)(36756003)(76176999)(305945005)(50986999)(81166006)(229853002)(81156014)(8936002)(50226002)(5820100001)(85426001)(99106002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR03MB2700;H:az84smr01.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD038;1:pJd7XqBsZdVO+L4Q7m9NSit7nwN2HMMho118F0ubaxoA9WRNft6+QqVojT40/bk/Fr1bzkd1R+xbmCCpL1nSZlVs+XoizLrhZ/jXndRg7OvdiROzxiwfOdZMMJL9WEdC X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7c108d60-7544-4d1c-368e-08d512579d1d X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017052603199)(201703131430075)(201703131517081);SRVR:DM5PR03MB2700; X-Microsoft-Exchange-Diagnostics: 1;DM5PR03MB2700;3:68uhVggMBSGLl5JFQ6PcRqnLPolosZPJYnb0BKFaPu0MPeOSdZzzKeShYMe4j3t9ZyIhsO6Dc18MBLI9ls8ddmmu901Iq/RsydYciCf8DeTSJl1kPiUH65/XNuV7SMXZo096NquiXGRxVO0k7degDPUjyOW25r3g61Jemz42pggFzGqP/1IhOp/5BdbgJPVb4hR+HHFKrJOUAzbjmbPstBkVDJiz7sIhE2nc9oAWg3qCX/H+FBbKNkNmlH/gVRx6ISNdylI3/05/b3y8Nidt7AIzyrfwxbaYd+kjvZpmAW08cKGLofBmqIvspWiNTcaHvMrwYH6moXz1dOplM1+FT06BeWglpRwwdUU3CdfqCug=;25:deRZFCdJhNTLXYhM2y+9KDD9a/sLOApp9cmFRdLRH7IQ2GflIe0BuY8Usw9V+4Ug6tUsuF2RrPfT1EnuqobepLPC8zy11jmxXcyI6vD7ctUzNk/kFV/agOcKtqz9bZJU8na2F/0vum1K/iKVNMvQtDzmepEzLkxH2n+U3g5IHh/UaWkpIuf6rxjX1Yqp8tCJ97sLrWgilBVXBkn373b1rl8dV+npHy82cpePH8DsOc63IxyGqtT19KWZs0quFYXnKN9kcWJvQkMIDDHpY8Ch51Nhob7UAE8IdkE4Fm584zy8hTYAGrIdDohUZGZdYhauyjOU/Cy8+sY6yvgNBoW/wA== X-MS-TrafficTypeDiagnostic: DM5PR03MB2700: X-Microsoft-Exchange-Diagnostics: 1;DM5PR03MB2700;31:+Ycwfhr5+sYu4qFQl+NZ2W1IiuTVUgEni5/Tqv1WW4Hh15WBep29GO+M+HcPDBe8ePWg+RaVKmCxw4ohx3jfzNrgWki/XlcpRN0kfqPBRGXwaKjijoVcxpieUcEPRimu92iez0uPnUdo7ZP8uUodV5du4vExfiO4TkI1ZMqZKteFeeNObt1rPVFdTx7HY54lcSkeLjwJwaLA6tdedfm67pLA29JfqO68KVmXvPVrl4A=;4:KfSGrPlv9hxH01ncqug/ynsgIbnccuIpOHjyNzutFUBcMEF0gez1mFYiUfArDpVHwtnxonCazFa3sXJngJhVskA6m1i5mQLKg8cn5NUk8PXfP5YsNFPRf35XFAdOSXuSEEQlOJEjAxzMFTIR03vC/khPa4iLkzcPFsHuvh+9Tx3ffAVfU27l8EhHB1fNzVGv/8kkYpgL5v+NaLMSZjy3v7lGTyforvlS+49/XywKgG4hFMUZXKBidgQSOj9ckIbW X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(3002001)(6055026)(6096035)(20161123563025)(20161123556025)(20161123565025)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(20161123561025)(20161123559100)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM5PR03MB2700;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM5PR03MB2700; X-Forefront-PRVS: 04599F3534 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjAzTUIyNzAwOzIzOlpWb1o2RVFERjBlMis2UWd5VlNvSGg2dDlY?= =?utf-8?B?WE04eCs1Ukg5UjFSNGwycklyNXZ5UmtXOUpFSjZwUkFtZzhCRlNMZUZ1VEtD?= =?utf-8?B?akZ5Z2ZOSzBqalhLd0lNTWsrWXZtQ2ZtNkFCN01YTk9KdnVCNGo4WHJkd2Fn?= =?utf-8?B?aEJxTEhPM3BKb2JQd0wrUlcyUSs0MmE5eWFIeVFFZHREZld0eUE3dlQyMDFG?= =?utf-8?B?NkZPc0NiNmM4bDg4cG5KNzlyeURaVDEvblJwd2doVkZhaTVRck1Yd2RrcGQy?= =?utf-8?B?Umh3dFJ1REIxTm1Qcmo1Qyt3TjlwMzg5OVZoZTF1c2g2alpKQXBPc2RBR2wv?= =?utf-8?B?VDB5MFFpRHJLcnNETWlZdllxc2JoeUROYzRBOCtYSW5SajRkS0RLOUhsRWwr?= =?utf-8?B?ak5HaTdiK3lwSFZ1eDdZTnVvOGl6VTVocnFxd3lic1V3VU5RU2RFbDg3L0Zu?= =?utf-8?B?VlN6S09QK1kzdW9oUHZmTzlhWS9KaG5Jek9WZGxYRnBWTnBrYlQrTlRxd3dz?= =?utf-8?B?RWFidWVEcjRTMnNPajl0VnFEN0Q4WnRIdWYxMWFpaWVkM1ozdjkwMnVlem1C?= =?utf-8?B?RVVMTUVWeHlUMVdBeFNiMFlEVkJtT21USEFhaGNHNkhmcXdVR0M3NzFsUUJn?= =?utf-8?B?c2ttV2hYNmRNWU1jZkdSakd6SmhsQlVuMHNLekkrY2lwckFNUDBLTHhBNlNB?= =?utf-8?B?Sk14Z3RHR2dRWXMxSVBOWElhZEJMZ3lCdk9pb2F3bEx6U01NTEQrcDJOdi9K?= =?utf-8?B?NVJ5Y0Q2VmdBRXBVL2RhaFpXbDgyR2NZYmJIcG8xbXI1TzVZUlFuZEpOV1ph?= =?utf-8?B?MXBUeGhwUDJyTzlPRHNKeWdmbm1ZMXpyRDFOQUl1YmtCSVB4S0FOTXlMem1w?= =?utf-8?B?cXUwYW9SYWY1dXVSQnJZOWM4RGNFbXZicjZ2UnVNMGtvQlhSc0xWKzFaRllN?= =?utf-8?B?TWdpR1hHTE5aWVhxRG04ejdlbVk0ZGxDS0FVN2RQS213OGpPYllPWndtUldl?= =?utf-8?B?OEhPNWFmYkovNWl0RmkvQnFXaVhBdDJRYVdEQTVSTXlDNnNGazdMNTRjc1VN?= =?utf-8?B?UEJrOUN2OVExYVlTWlBYVDV3VWJDb3lUYzNTYThWSmFiaE1OTy82OVVIZUlG?= =?utf-8?B?NldJeUoxK0cxeHlQRk9FN3dXTWRHQjJyeEZpc2t3TTFUY1UrLzJjck5pb0RM?= =?utf-8?B?Z3lnUUNackVnTkxiZTZsRVh4cUJBMVdQZVhnREJ2aDg1WVZSOEEwY2dPekNZ?= =?utf-8?B?Sm94MXRPK2Z3MlJyeGsxZDF5cVB1MVAwRDBvTHkyY0tvL2k1bG5UZTBmY08z?= =?utf-8?B?RnpqVnFXekZ5aXI2WFlWcCtGVGQxTzFHck9FUUQrOHlUN2d2bjVIWlZ0eGsy?= =?utf-8?B?MjI3SVEydDFvRE5vYWIvbUU3NkRFWjc0aUNVcEdqYXE2MVhvYnFHMDBBVEF6?= =?utf-8?B?M3pBRWNGd1RrajQyQjlhZzlnU2RHU3B2Z3NMOGpGNU96ejBvbGhOeis1MTMy?= =?utf-8?B?QTcvd1JQV3hueFJOKzBaTWFhOFBzZE5hS3ZxRXBjM3VKZ09xb1c1UEFIM1Z4?= =?utf-8?B?NTdFcGM5dC9vc1IxR0xBZTFqSWdVNHV0TmR1OWwvVXd4MnVhK3ExNllHMEN6?= =?utf-8?B?RE4wVzAvUk1mdnhlczQzUFBLbkU2MHVHdU9yekxLTWNaL25XcWhyMHdZN1NN?= =?utf-8?B?VVJRSCsySFRrMlFXaHJqQnZCNjNnY3MwRDQ1cjY5YitiajZoNEwzTDBISTZJ?= =?utf-8?B?TGlCZ01OOHVBUHI2R3dxQT09?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR03MB2700;6:UFcMKnG6zp24cKc7H6XUp+38qaV035K0ZGvv+GocCRVLusYtaP7+xDbriK91BDIlynfe+Z2APe4slTxgrhZ9jWEOZO2Zq4Tx58sAeclVAdfEiJMRToTgquhvccm1CfWCl0dRkOIEzthCMfqXUWNa7BDnEr/23FW1FslD56/NHzZpgv+3R2uCfJ3NMb78JWKh2+QMG7eecuBU9ZZToxC6cQpZjHsHrut/IyA84+ch7W5aeanQtuvM/CaumQ+n0di4DEZDbJE3fdP6bazVsVtqylPC8ezBwCJEs9pJr9At8q+0KGYN8bpmtRL6fKdJNArWBWIwKeEfgzULPVYd7z64Fg==;5:RMK8MkdPZMhwaqoPMWsd87k14JSwnaLiRy9KyKKVoYGFIrBtYxkK4XBOP/kokSrU/AWWrVRJpkI6ROUxng1aA/Cfmp2g46TN1xb1ARJr3L+i3qLADqP41s6vI9RkZACXybIg///Gz3nF6MxBre34vJyUoyEXuq5CU6vApecoNnY=;24:PP578xE/URGMvJwZrvkG05G86nDaPOhyQ/KMskcqfFhU8Ybv7IldzmNKLVB5fsgLPJ5tdThO6dVr7anCTCqICgyedE3iU6UdeXIF90VjlKk=;7:HHext5pm5xwT3MGF+jEL1tbAcV+nTTI4gn+nbjLWce/f5pozYcTxzUPCgWlcc0WPC0O4P1uDq9fPBGU9BQ6Fv1utu5bKl8Asj5qJWbeu5yfi2u8zQYGfsjHICmh501YcWK48f/IlNWskK6aJZOBvUCjz/CJuFrqelVPbSUokzj5WJsbCtqaFX867/nRVPHF3RNDMTnGy4NPu3sqSPb81Y8lIFVjsQMHprHPxrcGWx4E= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2017 16:29:44.8157 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2700 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2017-08-27 at 15:58 +0200, Pierre-Hugues Husson wrote: > Extend the driver to support Ricoh RC5T619. > Support the additional regulators and slightly different voltage ranges. > > @@ -101,10 +131,7 @@ static int rn5t618_regulator_probe(struct platform_device *pdev) >   config.dev = pdev->dev.parent; >   config.regmap = rn5t618->regmap; >   > - for (i = 0; i < RN5T618_REG_NUM; i++) { > - if (!regulators[i].name) > - continue; > - > + for (i = 0; i < num_regulators; i++) { >   rdev = devm_regulator_register(&pdev->dev, >          ®ulators[i], >          &config); This is wrong. The rn5t*_regulators arrays are indexed by RN5T618_* constants and can have gaps. If you remove the check for regulators[i].name then older models get errors like this: rn5t618-regulator rn5t618-regulator: failed to register (null) regulator rn5t618-regulator: probe of rn5t618-regulator failed with error -22 Either the check needs to be kep or otherwise regulator_desc arrays should be modified. Indexing by RN5T618_* does not appear to be used so maybe just use a flat array? That would also save a few bytes of memory. I know it's a late comment and the patch was already accepted, I just noticed that rn5t567 fails to probe while working on something else. -- Regards, Leonard