From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753247AbdJMTjT (ORCPT ); Fri, 13 Oct 2017 15:39:19 -0400 Received: from mail-wr0-f181.google.com ([209.85.128.181]:47681 "EHLO mail-wr0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751623AbdJMTjQ (ORCPT ); Fri, 13 Oct 2017 15:39:16 -0400 X-Google-Smtp-Source: AOwi7QAVsnW3E6FJVHG6P15rlp3WY6dQG74VMqD3e75MPZCcQGEgpfMwVnuNRy2GQ5q55lN07pP9ug== Message-ID: <1507923553.30658.10.camel@baylibre.com> Subject: Re: [PATCH] nvmem: meson: use generic compatible From: Jerome Brunet To: Martin Blumenstingl Cc: Srinivas Kandagatla , Kevin Hilman , Carlo Caione , devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Fri, 13 Oct 2017 21:39:13 +0200 In-Reply-To: References: <20171012152450.12454-1-jbrunet@baylibre.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.24.6 (3.24.6-1.fc26) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-10-13 at 21:14 +0200, Martin Blumenstingl wrote: > Hi Jerome, > > On Thu, Oct 12, 2017 at 5:24 PM, Jerome Brunet wrote: > > The meson efuse driver seems to be compatible with more SoCs than > > initially thought. Let's use the most generic compatible he have in > > DT instead of the gxbb specific one > > > > Signed-off-by: Jerome Brunet > > --- > > Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt | 4 ++-- > > drivers/nvmem/meson-efuse.c | 2 +- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt > > b/Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt > > index fafd85bd67a6..0260524292fe 100644 > > --- a/Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt > > +++ b/Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt > > @@ -1,7 +1,7 @@ > > = Amlogic eFuse device tree bindings = > > > > Required properties: > > -- compatible: should be "amlogic,meson-gxbb-efuse" > > +- compatible: should be "amlogic,meson-gx-efuse" > > have you checked with the devicetree maintainers how they want the > documentation to look like in this case? You mean "Should we put every compatible existing (in DT) in the documentation" >>From what I've seen, at least in meson drivers, only the matched ones are listed. That's a good question though. We tend to put soc specific compatible "in case" we need them later on. Should we document those ? > (I don't know if the old one should be kept instead of removing it) > > > > > = Data cells = > > Are child nodes of eFuse, bindings of which as described in > > @@ -10,7 +10,7 @@ bindings/nvmem/nvmem.txt > > Example: > > > > efuse: efuse { > > - compatible = "amlogic,meson-gxbb-efuse"; > > + compatible = "amlogic,meson-gx-efuse"; > > #address-cells = <1>; > > #size-cells = <1>; > > > > diff --git a/drivers/nvmem/meson-efuse.c b/drivers/nvmem/meson-efuse.c > > index 70bfc9839bb2..e90c6d68a263 100644 > > --- a/drivers/nvmem/meson-efuse.c > > +++ b/drivers/nvmem/meson-efuse.c > > @@ -44,7 +44,7 @@ static struct nvmem_config econfig = { > > }; > > > > static const struct of_device_id meson_efuse_match[] = { > > - { .compatible = "amlogic,meson-gxbb-efuse", }, > > + { .compatible = "amlogic,meson-gx-efuse", }, > > { /* sentinel */ }, > > }; > > MODULE_DEVICE_TABLE(of, meson_efuse_match); > > -- > > 2.13.6 > > > > > > _______________________________________________ > > linux-amlogic mailing list > > linux-amlogic@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-amlogic