[PATCH] Staging: speakup: Replace symbolic permissions with octal permissions

[PATCH] Staging: speakup: Replace symbolic permissions with octal permissions

[Shreeya Patel]

Resolve following checkpatch issue:
WARNING: Symbolic permissions 'S_IRUGO' are not preferred.
Consider using octal permissions '0444'.

Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
---
 drivers/staging/speakup/speakup_bns.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/speakup_bns.c b/drivers/staging/speakup/speakup_bns.c
index 60bcf0d..402b0fb 100644
--- a/drivers/staging/speakup/speakup_bns.c
+++ b/drivers/staging/speakup/speakup_bns.c
@@ -120,7 +120,7 @@ static struct spk_synth synth_bns = {
 };
 
 module_param_named(ser, synth_bns.ser, int, 0444);
-module_param_named(dev, synth_bns.dev_name, charp, S_IRUGO);
+module_param_named(dev, synth_bns.dev_name, charp, 0444);
 module_param_named(start, synth_bns.startup, short, 0444);
 
 MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based).");
-- 
2.7.4

Re: [Outreachy kernel] [PATCH] Staging: speakup: Replace symbolic permissions with octal permissions

[Julia Lawall]

On Sat, 14 Oct 2017, Shreeya Patel wrote:

> Resolve following checkpatch issue:
> WARNING: Symbolic permissions 'S_IRUGO' are not preferred.
> Consider using octal permissions '0444'.
>
> Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
> ---
>  drivers/staging/speakup/speakup_bns.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/speakup_bns.c b/drivers/staging/speakup/speakup_bns.c
> index 60bcf0d..402b0fb 100644
> --- a/drivers/staging/speakup/speakup_bns.c
> +++ b/drivers/staging/speakup/speakup_bns.c
> @@ -120,7 +120,7 @@ static struct spk_synth synth_bns = {
>  };
>
>  module_param_named(ser, synth_bns.ser, int, 0444);
> -module_param_named(dev, synth_bns.dev_name, charp, S_IRUGO);
> +module_param_named(dev, synth_bns.dev_name, charp, 0444);

This change is already made.  You need to update your staging tree.

julia

>  module_param_named(start, synth_bns.startup, short, 0444);
>
>  MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based).");
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1507930425-5471-1-git-send-email-shreeya.patel23498%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH] Staging: speakup: Replace symbolic permissions with octal permissions

[Shreeya Patel]

On Fri, 2017-10-13 at 23:44 +0200, Julia Lawall wrote:
> 
> On Sat, 14 Oct 2017, Shreeya Patel wrote:
> 
> > 
> > Resolve following checkpatch issue:
> > WARNING: Symbolic permissions 'S_IRUGO' are not preferred.
> > Consider using octal permissions '0444'.
> > 
> > Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
> > ---
> >  drivers/staging/speakup/speakup_bns.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/speakup/speakup_bns.c
> > b/drivers/staging/speakup/speakup_bns.c
> > index 60bcf0d..402b0fb 100644
> > --- a/drivers/staging/speakup/speakup_bns.c
> > +++ b/drivers/staging/speakup/speakup_bns.c
> > @@ -120,7 +120,7 @@ static struct spk_synth synth_bns = {
> >  };
> > 
> >  module_param_named(ser, synth_bns.ser, int, 0444);
> > -module_param_named(dev, synth_bns.dev_name, charp, S_IRUGO);
> > +module_param_named(dev, synth_bns.dev_name, charp, 0444);
> This change is already made.  You need to update your staging tree.
> 
> julia

Oh, ok i'll do it.


> 
> > 
> >  module_param_named(start, synth_bns.startup, short, 0444);
> > 
> >  MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-
> > based).");
> > --
> > 2.7.4
> > 
> > --
> > You received this message because you are subscribed to the Google
> > Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it,
> > send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.
> > com.
> > To view this discussion on the web visit https://groups.google.com/
> > d/msgid/outreachy-kernel/1507930425-5471-1-git-send-email-
> > shreeya.patel23498%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >