From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752876AbdJMVqI (ORCPT ); Fri, 13 Oct 2017 17:46:08 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:46976 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751057AbdJMVqH (ORCPT ); Fri, 13 Oct 2017 17:46:07 -0400 X-Google-Smtp-Source: AOwi7QDPzzVTz70aYVHDEdVy02l1IgMOupL0xEFVCRGTlhEt1HIN0mauxJs2mkxB/n1ffi50hPR09A== Message-ID: <1507931160.5597.0.camel@gmail.com> Subject: Re: [Outreachy kernel] [PATCH] Staging: speakup: Replace symbolic permissions with octal permissions From: Shreeya Patel To: Julia Lawall Cc: gregkh@linuxfoundation.org, w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca, samuel.thibault@ens-lyon.org, speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Date: Sat, 14 Oct 2017 03:16:00 +0530 In-Reply-To: References: <1507930425-5471-1-git-send-email-shreeya.patel23498@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-10-13 at 23:44 +0200, Julia Lawall wrote: > > On Sat, 14 Oct 2017, Shreeya Patel wrote: > > > > > Resolve following checkpatch issue: > > WARNING: Symbolic permissions 'S_IRUGO' are not preferred. > > Consider using octal permissions '0444'. > > > > Signed-off-by: Shreeya Patel > > --- > >  drivers/staging/speakup/speakup_bns.c | 2 +- > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/speakup/speakup_bns.c > > b/drivers/staging/speakup/speakup_bns.c > > index 60bcf0d..402b0fb 100644 > > --- a/drivers/staging/speakup/speakup_bns.c > > +++ b/drivers/staging/speakup/speakup_bns.c > > @@ -120,7 +120,7 @@ static struct spk_synth synth_bns = { > >  }; > > > >  module_param_named(ser, synth_bns.ser, int, 0444); > > -module_param_named(dev, synth_bns.dev_name, charp, S_IRUGO); > > +module_param_named(dev, synth_bns.dev_name, charp, 0444); > This change is already made.  You need to update your staging tree. > > julia Oh, ok i'll do it. > > > > >  module_param_named(start, synth_bns.startup, short, 0444); > > > >  MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0- > > based)."); > > -- > > 2.7.4 > > > > -- > > You received this message because you are subscribed to the Google > > Groups "outreachy-kernel" group. > > To unsubscribe from this group and stop receiving emails from it, > > send an email to outreachy-kernel+unsubscribe@googlegroups.com. > > To post to this group, send email to outreachy-kernel@googlegroups. > > com. > > To view this discussion on the web visit https://groups.google.com/ > > d/msgid/outreachy-kernel/1507930425-5471-1-git-send-email- > > shreeya.patel23498%40gmail.com. > > For more options, visit https://groups.google.com/d/optout. > >