From: Joe Perches <joe@perches.com>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>,
Andy Whitcroft <apw@canonical.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: scripts/checkpatch: Concatenated strings should use spaces between elements
Date: Tue, 17 Oct 2017 15:43:12 -0700 [thread overview]
Message-ID: <1508280192.6530.31.camel@perches.com> (raw)
In-Reply-To: <20171017211751.31343-1-xypron.glpk@gmx.de>
On Tue, 2017-10-17 at 23:17 +0200, Heinrich Schuchardt wrote:
> This patch creates a warning (CHECK)
> "Concatenated strings should use spaces between elements"
>
> There are no concatenated strings here.
Yes, there are.
> (checkpatch is also used in the U-Boot project where wide strings
> occur in the EFI implementation.)
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> test.c | 7 +++++++
> 1 file changed, 7 insertions(+)
> create mode 100644 test.c
>
> diff --git a/test.c b/test.c
> new file mode 100644
> index 0000000000..dfd33cd765
> --- /dev/null
> +++ b/test.c
> @@ -0,0 +1,6 @@
> +#include <foo.h>
> +
> +void foo(void)
> +{
> + test(L"\"");
In this case, L must be a constant string and you
are concatenating L and "\""
next prev parent reply other threads:[~2017-10-17 22:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 21:17 scripts/checkpatch: Concatenated strings should use spaces between elements Heinrich Schuchardt
2017-10-17 22:43 ` Joe Perches [this message]
2017-10-17 22:58 ` Heinrich Schuchardt
2017-10-17 23:18 ` Joe Perches
2017-10-18 0:35 ` Joe Perches
2017-10-18 6:32 ` Heinrich Schuchardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508280192.6530.31.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox