From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764676AbdJQWnR (ORCPT ); Tue, 17 Oct 2017 18:43:17 -0400 Received: from smtprelay0014.hostedemail.com ([216.40.44.14]:39132 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758839AbdJQWnP (ORCPT ); Tue, 17 Oct 2017 18:43:15 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:800:960:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3868:3870:3871:3873:4250:4321:4559:5007:7904:10004:10400:10848:11232:11658:11914:12555:12740:12760:12895:12986:13069:13311:13357:13439:14181:14659:14721:21080:21451:21627:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: ocean74_1c300a430a829 X-Filterd-Recvd-Size: 1572 Message-ID: <1508280192.6530.31.camel@perches.com> Subject: Re: scripts/checkpatch: Concatenated strings should use spaces between elements From: Joe Perches To: Heinrich Schuchardt , Andy Whitcroft Cc: linux-kernel@vger.kernel.org Date: Tue, 17 Oct 2017 15:43:12 -0700 In-Reply-To: <20171017211751.31343-1-xypron.glpk@gmx.de> References: <20171017211751.31343-1-xypron.glpk@gmx.de> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-10-17 at 23:17 +0200, Heinrich Schuchardt wrote: > This patch creates a warning (CHECK) > "Concatenated strings should use spaces between elements" > > There are no concatenated strings here. Yes, there are. > (checkpatch is also used in the U-Boot project where wide strings > occur in the EFI implementation.) > > Signed-off-by: Heinrich Schuchardt > --- > test.c | 7 +++++++ > 1 file changed, 7 insertions(+) > create mode 100644 test.c > > diff --git a/test.c b/test.c > new file mode 100644 > index 0000000000..dfd33cd765 > --- /dev/null > +++ b/test.c > @@ -0,0 +1,6 @@ > +#include > + > +void foo(void) > +{ > + test(L"\""); In this case, L must be a constant string and you are concatenating L and "\""