* Re: [PATCH for-next] IB,hfi1 Add MODULE_FIRMWARE statements
2017-10-11 15:31 ` Dennis Dalessandro
@ 2017-10-11 15:32 ` Dennis Dalessandro
2017-10-11 15:49 ` Leon Romanovsky
2017-10-11 15:54 ` Thomas Bogendoerfer
2 siblings, 0 replies; 8+ messages in thread
From: Dennis Dalessandro @ 2017-10-11 15:32 UTC (permalink / raw)
To: Thomas Bogendoerfer, Mike Marciniszyn, Doug Ledford, Sean Hefty,
Hal Rosenstock, linux-rdma, linux-kernel
On 10/11/2017 11:31 AM, Dennis Dalessandro wrote:
> On 10/11/2017 8:41 AM, Thomas Bogendoerfer wrote:
>> Provide information about used firmware files via modinfo.
>>
>> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
>> ---
>> drivers/infiniband/hw/hfi1/firmware.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/infiniband/hw/hfi1/firmware.c
>> b/drivers/infiniband/hw/hfi1/firmware.c
>> index dee3c674f33d..f56ace76b42c 100644
>> --- a/drivers/infiniband/hw/hfi1/firmware.c
>> +++ b/drivers/infiniband/hw/hfi1/firmware.c
>> @@ -70,6 +70,11 @@
>> #define ALT_FW_PCIE_NAME "hfi1_pcie_d.fw"
>> #define HOST_INTERFACE_VERSION 1
>> +MODULE_FIRMWARE(DEFAULT_FW_8051_NAME_ASIC);
>> +MODULE_FIRMWARE(DEFAULT_FW_FABRIC_NAME);
>> +MODULE_FIRMWARE(DEFAULT_FW_SBUS_NAME);
>> +MODULE_FIRMWARE(DEFAULT_FW_PCIE_NAME);
>> +
>> static uint fw_8051_load = 1;
>> static uint fw_fabric_serdes_load = 1;
>> static uint fw_pcie_serdes_load = 1;
>>
>
> I don't find this terribly useful, but if it's useful for you I'm sure
> it is for others as well, so I have no problem with it.
>
> Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Although you may want to change the subject from IB,hfi1 to IB/hfi1.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH for-next] IB,hfi1 Add MODULE_FIRMWARE statements
2017-10-11 15:31 ` Dennis Dalessandro
2017-10-11 15:32 ` Dennis Dalessandro
@ 2017-10-11 15:49 ` Leon Romanovsky
2017-10-11 17:13 ` Dennis Dalessandro
2017-10-11 15:54 ` Thomas Bogendoerfer
2 siblings, 1 reply; 8+ messages in thread
From: Leon Romanovsky @ 2017-10-11 15:49 UTC (permalink / raw)
To: Dennis Dalessandro
Cc: Thomas Bogendoerfer, Mike Marciniszyn, Doug Ledford, Sean Hefty,
Hal Rosenstock, linux-rdma, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1263 bytes --]
On Wed, Oct 11, 2017 at 11:31:18AM -0400, Dennis Dalessandro wrote:
> On 10/11/2017 8:41 AM, Thomas Bogendoerfer wrote:
> > Provide information about used firmware files via modinfo.
> >
> > Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> > ---
> > drivers/infiniband/hw/hfi1/firmware.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/infiniband/hw/hfi1/firmware.c b/drivers/infiniband/hw/hfi1/firmware.c
> > index dee3c674f33d..f56ace76b42c 100644
> > --- a/drivers/infiniband/hw/hfi1/firmware.c
> > +++ b/drivers/infiniband/hw/hfi1/firmware.c
> > @@ -70,6 +70,11 @@
> > #define ALT_FW_PCIE_NAME "hfi1_pcie_d.fw"
> > #define HOST_INTERFACE_VERSION 1
> > +MODULE_FIRMWARE(DEFAULT_FW_8051_NAME_ASIC);
> > +MODULE_FIRMWARE(DEFAULT_FW_FABRIC_NAME);
> > +MODULE_FIRMWARE(DEFAULT_FW_SBUS_NAME);
> > +MODULE_FIRMWARE(DEFAULT_FW_PCIE_NAME);
> > +
> > static uint fw_8051_load = 1;
> > static uint fw_fabric_serdes_load = 1;
> > static uint fw_pcie_serdes_load = 1;
> >
>
> I don't find this terribly useful, but if it's useful for you I'm sure it is
> for others as well, so I have no problem with it.
Dennis,
Aren't those defines being constant?
>
> Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH for-next] IB,hfi1 Add MODULE_FIRMWARE statements
2017-10-11 15:49 ` Leon Romanovsky
@ 2017-10-11 17:13 ` Dennis Dalessandro
2017-10-11 18:10 ` Leon Romanovsky
0 siblings, 1 reply; 8+ messages in thread
From: Dennis Dalessandro @ 2017-10-11 17:13 UTC (permalink / raw)
To: Leon Romanovsky
Cc: Thomas Bogendoerfer, Mike Marciniszyn, Doug Ledford, Sean Hefty,
Hal Rosenstock, linux-rdma, linux-kernel
On 10/11/2017 11:49 AM, Leon Romanovsky wrote:
> On Wed, Oct 11, 2017 at 11:31:18AM -0400, Dennis Dalessandro wrote:
>> On 10/11/2017 8:41 AM, Thomas Bogendoerfer wrote:
>>> Provide information about used firmware files via modinfo.
>>>
>>> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
>>> ---
>>> drivers/infiniband/hw/hfi1/firmware.c | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/drivers/infiniband/hw/hfi1/firmware.c b/drivers/infiniband/hw/hfi1/firmware.c
>>> index dee3c674f33d..f56ace76b42c 100644
>>> --- a/drivers/infiniband/hw/hfi1/firmware.c
>>> +++ b/drivers/infiniband/hw/hfi1/firmware.c
>>> @@ -70,6 +70,11 @@
>>> #define ALT_FW_PCIE_NAME "hfi1_pcie_d.fw"
>>> #define HOST_INTERFACE_VERSION 1
>>> +MODULE_FIRMWARE(DEFAULT_FW_8051_NAME_ASIC);
>>> +MODULE_FIRMWARE(DEFAULT_FW_FABRIC_NAME);
>>> +MODULE_FIRMWARE(DEFAULT_FW_SBUS_NAME);
>>> +MODULE_FIRMWARE(DEFAULT_FW_PCIE_NAME);
>>> +
>>> static uint fw_8051_load = 1;
>>> static uint fw_fabric_serdes_load = 1;
>>> static uint fw_pcie_serdes_load = 1;
>>>
>>
>> I don't find this terribly useful, but if it's useful for you I'm sure it is
>> for others as well, so I have no problem with it.
>
> Dennis,
> Aren't those defines being constant?
>
>>
>> Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Which is why I didn't find it very useful. However Thomas makes a good
point [1].
https://marc.info/?l=linux-rdma&m=150773727811239&w=2
-Denny
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH for-next] IB,hfi1 Add MODULE_FIRMWARE statements
2017-10-11 17:13 ` Dennis Dalessandro
@ 2017-10-11 18:10 ` Leon Romanovsky
0 siblings, 0 replies; 8+ messages in thread
From: Leon Romanovsky @ 2017-10-11 18:10 UTC (permalink / raw)
To: Dennis Dalessandro
Cc: Thomas Bogendoerfer, Mike Marciniszyn, Doug Ledford, Sean Hefty,
Hal Rosenstock, linux-rdma, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1780 bytes --]
On Wed, Oct 11, 2017 at 01:13:26PM -0400, Dennis Dalessandro wrote:
> On 10/11/2017 11:49 AM, Leon Romanovsky wrote:
> > On Wed, Oct 11, 2017 at 11:31:18AM -0400, Dennis Dalessandro wrote:
> > > On 10/11/2017 8:41 AM, Thomas Bogendoerfer wrote:
> > > > Provide information about used firmware files via modinfo.
> > > >
> > > > Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> > > > ---
> > > > drivers/infiniband/hw/hfi1/firmware.c | 5 +++++
> > > > 1 file changed, 5 insertions(+)
> > > >
> > > > diff --git a/drivers/infiniband/hw/hfi1/firmware.c b/drivers/infiniband/hw/hfi1/firmware.c
> > > > index dee3c674f33d..f56ace76b42c 100644
> > > > --- a/drivers/infiniband/hw/hfi1/firmware.c
> > > > +++ b/drivers/infiniband/hw/hfi1/firmware.c
> > > > @@ -70,6 +70,11 @@
> > > > #define ALT_FW_PCIE_NAME "hfi1_pcie_d.fw"
> > > > #define HOST_INTERFACE_VERSION 1
> > > > +MODULE_FIRMWARE(DEFAULT_FW_8051_NAME_ASIC);
> > > > +MODULE_FIRMWARE(DEFAULT_FW_FABRIC_NAME);
> > > > +MODULE_FIRMWARE(DEFAULT_FW_SBUS_NAME);
> > > > +MODULE_FIRMWARE(DEFAULT_FW_PCIE_NAME);
> > > > +
> > > > static uint fw_8051_load = 1;
> > > > static uint fw_fabric_serdes_load = 1;
> > > > static uint fw_pcie_serdes_load = 1;
> > > >
> > >
> > > I don't find this terribly useful, but if it's useful for you I'm sure it is
> > > for others as well, so I have no problem with it.
> >
> > Dennis,
> > Aren't those defines being constant?
> >
> > >
> > > Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
>
> Which is why I didn't find it very useful. However Thomas makes a good point
> [1].
>
> https://marc.info/?l=linux-rdma&m=150773727811239&w=2
Right, just grepped now and see mlxsw using it too.
Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH for-next] IB,hfi1 Add MODULE_FIRMWARE statements
2017-10-11 15:31 ` Dennis Dalessandro
2017-10-11 15:32 ` Dennis Dalessandro
2017-10-11 15:49 ` Leon Romanovsky
@ 2017-10-11 15:54 ` Thomas Bogendoerfer
2 siblings, 0 replies; 8+ messages in thread
From: Thomas Bogendoerfer @ 2017-10-11 15:54 UTC (permalink / raw)
To: Dennis Dalessandro
Cc: Mike Marciniszyn, Doug Ledford, Sean Hefty, Hal Rosenstock,
linux-rdma, linux-kernel
On Wed, 11 Oct 2017 11:31:18 -0400
Dennis Dalessandro <dennis.dalessandro@intel.com> wrote:
> On 10/11/2017 8:41 AM, Thomas Bogendoerfer wrote:
> I don't find this terribly useful, but if it's useful for you I'm sure
> it is for others as well, so I have no problem with it.
well it's not so much about myself, but more about tools, which pull in firmware files
into initramfs.
Thomas.
--
SUSE Linux GmbH
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
^ permalink raw reply [flat|nested] 8+ messages in thread