From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751659AbdJROaD (ORCPT ); Wed, 18 Oct 2017 10:30:03 -0400 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:56759 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751048AbdJROaA (ORCPT ); Wed, 18 Oct 2017 10:30:00 -0400 X-IronPort-AV: E=Sophos;i="5.43,397,1503331200"; d="scan'208";a="58271398" From: Bart Van Assche To: "mingo@kernel.org" , "peterz@infradead.org" , "byungchul.park@lge.com" CC: "linux-kernel@vger.kernel.org" , "amir73il@gmail.com" , "linux-block@vger.kernel.org" , "hch@infradead.org" , "linux-xfs@vger.kernel.org" , "tglx@linutronix.de" , "linux-mm@kvack.org" , "oleg@redhat.com" , "darrick.wong@oracle.com" , "johannes.berg@intel.com" , "linux-fsdevel@vger.kernel.org" , "idryomov@gmail.com" , "tj@kernel.org" , "kernel-team@lge.com" , "david@fromorbit.com" Subject: Re: Fix false positive by LOCKDEP_CROSSRELEASE Thread-Topic: Fix false positive by LOCKDEP_CROSSRELEASE Thread-Index: AQHTR/T2HFZQdgnFYEKA0yaGZnAhaaLpqziA Date: Wed, 18 Oct 2017 14:29:56 +0000 Message-ID: <1508336995.2923.2.camel@wdc.com> References: <1508319532-24655-1-git-send-email-byungchul.park@lge.com> In-Reply-To: <1508319532-24655-1-git-send-email-byungchul.park@lge.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [73.223.62.206] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1533;20:dL3uE3QYttcwT4vNa1HkfBuwyXw8rgm4s1JgJ1GNJnN+yeTdLuCownTBtmx569TvXgZ9ny1H5+yxMdeqmT736LlV3dbuxo41uKnUvMgsN8/B+uEl3qOD+p5hegliiXogItt/dSm8lxeCFB5DGctinh2ff1bG+G2djyFVVdPk9ek= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 668dc65a-39f4-4750-8730-08d51634b4aa x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:CY1PR0401MB1533; x-ms-traffictypediagnostic: CY1PR0401MB1533: wdcipoutbound: EOP-TRUE x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(6055026)(6041248)(20161123560025)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR0401MB1533;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR0401MB1533; x-forefront-prvs: 0464DBBBC4 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(376002)(346002)(377424004)(24454002)(189002)(199003)(8936002)(14454004)(3280700002)(189998001)(68736007)(5660300001)(25786009)(4001150100001)(101416001)(54356999)(50986999)(2900100001)(99286003)(3660700001)(8676002)(7416002)(2950100002)(478600001)(6436002)(81156014)(72206003)(81166006)(76176999)(36756003)(3846002)(229853002)(2501003)(6512007)(66066001)(305945005)(106356001)(7736002)(6116002)(102836003)(39060400002)(86362001)(4326008)(2201001)(54906003)(110136005)(103116003)(6246003)(6486002)(97736004)(77096006)(316002)(6506006)(105586002)(2906002)(33646002)(53936002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1533;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2017 14:29:56.6571 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1533 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v9IEU8Jl025394 On Wed, 2017-10-18 at 18:38 +0900, Byungchul Park wrote: > Several false positives were reported, so I tried to fix them. > > It would be appreciated if you tell me if it works as expected, or let > me know your opinion. What I have been wondering about is whether the crosslock checking makes sense from a conceptual point of view. I tried to find documentation for the crosslock checking in Documentation/locking/lockdep-design.txt but couldn't find a description of the crosslock checking. Shouldn't it be documented somewhere what the crosslock checks do and what the theory is behind these checks? Bart.