From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752845AbdJSL3c (ORCPT ); Thu, 19 Oct 2017 07:29:32 -0400 Received: from smtprelay0038.hostedemail.com ([216.40.44.38]:35793 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752002AbdJSL3b (ORCPT ); Thu, 19 Oct 2017 07:29:31 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:960:973:982:988:989:1042:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:2895:2899:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3871:3873:3874:4321:5007:6691:7903:10004:10400:10848:11232:11658:11914:12043:12740:12895:13069:13095:13255:13311:13357:13439:13894:14659:14721:21080:21212:21433:21451:21627:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: flag70_52cea4f5ef32a X-Filterd-Recvd-Size: 1726 Message-ID: <1508412567.6806.36.camel@perches.com> Subject: Re: kernel/module: Delete an error message for a failed memory allocation in add_module_usage() From: Joe Perches To: SF Markus Elfring , Jessica Yu Cc: kernel-janitors@vger.kernel.org, Rusty Russell , LKML Date: Thu, 19 Oct 2017 04:29:27 -0700 In-Reply-To: <43c71898-82c3-215a-3176-e1a6d56ef10a@users.sourceforge.net> References: <20171019110824.wqkep7bpcx3dcw5w@redbean> <43c71898-82c3-215a-3176-e1a6d56ef10a@users.sourceforge.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-10-19 at 13:18 +0200, SF Markus Elfring wrote: > > > Omit an extra message for a memory allocation failure in this function. > > > > > > This issue was detected by using the Coccinelle software. > > > > > > Signed-off-by: Markus Elfring > > > > Applied to modules-next, thanks. > > Thanks for your acceptance of this update suggestion after a bit of clarification. > > Do you see any need that I should extend subsequent commit messages > for this software transformation pattern? Add a description of _why_ this is being done. Something like: "because there is a dump_stack() done on allocation failures without __GFP_JNOWARN"