From: Joe Perches <joe@perches.com>
To: Guenter Roeck <linux@roeck-us.net>,
Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
cphealy@gmail.com, Lucas Stach <l.stach@pengutronix.de>,
Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
Lee Jones <lee.jones@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Pavel Machek <pavel@ucw.cz>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Rob Herring <robh@kernel.org>, Johan Hovold <johan@kernel.org>
Subject: Re: [v8,4/5] watchdog: Add RAVE SP watchdog driver
Date: Sat, 21 Oct 2017 16:34:06 -0700 [thread overview]
Message-ID: <1508628846.14611.2.camel@perches.com> (raw)
In-Reply-To: <20171021164730.GA20402@roeck-us.net>
On Sat, 2017-10-21 at 09:47 -0700, Guenter Roeck wrote:
> On Wed, Oct 18, 2017 at 10:01:35AM -0700, Andrey Smirnov wrote:
> > This driver provides access to RAVE SP watchdog functionality.
[]
> > +static int rave_sp_wdt_legacy_configure(struct watchdog_device *wdd)
> > +{
> > + const bool enable = watchdog_hw_running(wdd);
> > + u8 cmd[] = {
> > + [0] = RAVE_SP_CMD_SW_WDT,
> > + [1] = 0,
> > + [2] = 0,
> > + [3] = !!enable,
>
> Useless !!. It converts a boolean to a boolean. Besides, isn't it always
> true anyway ?
This converts a _Bool to an int which is cast to a u8
The !! is useless though.
> > + [4] = enable ? wdd->timeout : 0,
> > + };
>
> Interesting; checkpatch doesn't require an empty line after variable
> declarations anymore ? Lets keep it anyway for consistency.
checkpatch is primarily a single line oriented parser.
Multi-line declarations aren't parsed.
next prev parent reply other threads:[~2017-10-21 23:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 17:01 [PATCH v8 0/5] ZII RAVE platform driver Andrey Smirnov
2017-10-18 17:01 ` [PATCH v8 1/5] serdev: Make .remove in struct serdev_device_driver optional Andrey Smirnov
2017-10-21 17:08 ` Guenter Roeck
2017-10-27 18:17 ` Sebastian Reichel
2017-10-18 17:01 ` [PATCH v8 2/5] serdev: Introduce devm_serdev_device_open() Andrey Smirnov
2017-10-21 17:09 ` Guenter Roeck
2017-10-28 9:48 ` Sebastian Reichel
2017-10-18 17:01 ` [PATCH v8 3/5] platform: Add driver for RAVE Supervisory Processor Andrey Smirnov
2017-10-21 17:17 ` Guenter Roeck
2017-10-23 17:07 ` Andrey Smirnov
2017-10-18 17:01 ` [PATCH v8 4/5] watchdog: Add RAVE SP watchdog driver Andrey Smirnov
2017-10-21 16:47 ` [v8,4/5] " Guenter Roeck
2017-10-21 23:34 ` Joe Perches [this message]
2017-10-23 17:01 ` Andrey Smirnov
2017-10-23 22:04 ` Guenter Roeck
2017-10-24 0:24 ` Andrey Smirnov
2017-10-18 17:01 ` [PATCH v8 5/5] dt-bindings: watchdog: Add bindings for " Andrey Smirnov
2017-10-24 19:07 ` Rob Herring
2017-10-25 15:00 ` Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508628846.14611.2.camel@perches.com \
--to=joe@perches.com \
--cc=andrew.smirnov@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=cphealy@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=l.stach@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nikita.yoush@cogentembedded.com \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox