From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751372AbdJWKPF (ORCPT ); Mon, 23 Oct 2017 06:15:05 -0400 Received: from s3.sipsolutions.net ([144.76.63.242]:45756 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751150AbdJWKPE (ORCPT ); Mon, 23 Oct 2017 06:15:04 -0400 Message-ID: <1508753691.2639.10.camel@sipsolutions.net> Subject: Re: [PATCH v2 31/37] mac80211_hwsim: Replace hrtimer tasklet with softirq hrtimer From: Johannes Berg To: Anna-Maria Gleixner , LKML Cc: Thomas Gleixner , Peter Zijlstra , Ingo Molnar , keescook@chromium.org, Christoph Hellwig , John Stultz , Kalle Valo , linux-wireless@vger.kernel.org Date: Mon, 23 Oct 2017 12:14:51 +0200 In-Reply-To: <20171022214053.576969587@linutronix.de> References: <20171022213938.940451689@linutronix.de> <20171022214053.576969587@linutronix.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.0-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2017-10-22 at 23:40 +0200, Anna-Maria Gleixner wrote: > From: Thomas Gleixner > > Switch the timer to HRTIMER_MODE_SOFT, which executed the timer > callback in softirq context and remove the hrtimer_tasklet. This doesn't build on my tree, due to HRTIMER_MODE_REL_SOFT not existing. Neither does HRTIMER_MODE_SOFT mentioned above, but that's just a commit log mistake. (It also didn't apply on my tree, but that was a trivial context change.) I don't understand why you initialize it with HRTIMER_MODE_ABS_SOFT either though: > + hrtimer_init(&data->beacon_timer, CLOCK_MONOTONIC, > + HRTIMER_MODE_ABS_SOFT); shouldn't that already be REL? johannes