From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751901AbdJYPD1 (ORCPT ); Wed, 25 Oct 2017 11:03:27 -0400 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:53939 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751692AbdJYPDX (ORCPT ); Wed, 25 Oct 2017 11:03:23 -0400 X-IronPort-AV: E=Sophos;i="5.43,432,1503331200"; d="scan'208";a="60025667" From: Bart Van Assche To: "keescook@chromium.org" , "Jason@zx2c4.com" CC: "linux-kernel@vger.kernel.org" , "jiangyilism@gmail.com" , "nab@linux-iscsi.org" , Bart Van Assche , "viro@zeniv.linux.org.uk" , "linux-scsi@vger.kernel.org" , "target-devel@vger.kernel.org" , "varun@chelsio.com" Subject: Re: [PATCH] iscsi-target: Convert timers to use timer_setup() Thread-Topic: [PATCH] iscsi-target: Convert timers to use timer_setup() Thread-Index: AQHTTXhJDdyLuqetZUaRBbaK0I93wqL0gkiAgAAY24CAAA6wgA== Date: Wed, 25 Oct 2017 15:03:19 +0000 Message-ID: <1508943795.4165.18.camel@wdc.com> References: <20171025100145.GA144703@beast> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [147.75.100.161] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1536;20:oXxPvQihfz7xrtaubNwCvl0i2giabLBlfP3SFLrALnALqYLVBUOu+xxP4lH1m/Q2aSG6G3FnA3/jGHeQYVJtFuzfCQvquFzgWiLexekqpHzJPxBbknYz3etia03pQv9z9Y2EXJYhjD5rFSg90y+8rBHZo1NWCg2+LlA8c2Mpjuk= x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-ms-office365-filtering-correlation-id: d408e14d-5fe2-4885-cfe6-08d51bb98750 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603199);SRVR:CY1PR0401MB1536; x-ms-traffictypediagnostic: CY1PR0401MB1536: wdcipoutbound: EOP-TRUE x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(3231020)(3002001)(10201501046)(6055026)(6041248)(20161123555025)(20161123560025)(20161123558100)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR0401MB1536;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR0401MB1536; x-forefront-prvs: 0471B73328 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(376002)(346002)(39860400002)(189002)(377424004)(199003)(24454002)(99286003)(102836003)(106356001)(6116002)(54356999)(25786009)(66066001)(3660700001)(3280700002)(105586002)(81156014)(101416001)(76176999)(103116003)(7736002)(2900100001)(50986999)(305945005)(54906003)(33646002)(97736004)(86362001)(14454004)(4001150100001)(316002)(2501003)(110136005)(39060400002)(4326008)(6436002)(6512007)(478600001)(229853002)(189998001)(6306002)(3846002)(36756003)(6246003)(53936002)(72206003)(8676002)(81166006)(6486002)(8936002)(5660300001)(77096006)(68736007)(6506006)(2906002)(2950100002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1536;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <738107933A99964D87B61120E8E11E93@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: d408e14d-5fe2-4885-cfe6-08d51bb98750 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2017 15:03:19.4819 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1536 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v9PF3WGE027936 On Wed, 2017-10-25 at 16:10 +0200, Kees Cook wrote: > However, maintainers: sorry to send this one -- it can't be merged > yet, this uses timer_setup_on_stack() which is only in -next right > now. If it looks okay, though, I can carry this in the timer tree. Hello Kees, Can you have a look at the following patch and queue it before your patch if you think this would be useful (this patch has been tested): "target/iscsi: Simplify timer manipulation code" (https://www.spinics.net/lists/target-devel/msg15385.html). Thanks, Bart.