public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene.kim@samsung.com>
To: "'Doug Anderson'" <dianders@chromium.org>,
	"'Linus Walleij'" <linus.walleij@linaro.org>
Cc: "'Tomasz Figa'" <tomasz.figa@gmail.com>,
	"'Olof Johansson'" <olof@lixom.net>,
	"'Simon Glass'" <sjg@chromium.org>,
	"'Luigi Semenzato'" <semenzato@chromium.org>,
	ilho215.lee@samsung.com, eunki_kim@samsung.com,
	linux-kernel@vger.kernel.org
Subject: RE: [PATCH 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking
Date: Thu, 13 Jun 2013 21:04:09 +0900	[thread overview]
Message-ID: <150901ce682e$1c3fca50$54bf5ef0$%kim@samsung.com> (raw)
In-Reply-To: <1371058399-31933-3-git-send-email-dianders@chromium.org>

Doug Anderson wrote:
> 
> A level-triggered interrupt should be acked after the interrupt line
> becomes inactive and before it is unmasked, or else another interrupt
> will be immediately triggered.  Acking before or after calling the
> handler is not enough.
> 
> Signed-off-by: Luigi Semenzato <semenzato@chromium.org>
> Signed-off-by: Doug Anderson <dianders@chromium.org>

BTW, probably we need a similar fixing in the mach-exynos/common.c file
before pinct기 for distro...

Anyway,
Acked-by: Kukjin Kim <kgene.kim@samsung.com>

Thanks,
- Kukjin


  parent reply	other threads:[~2013-06-13 12:04 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-12 17:33 [PATCH 1/3] pinctrl: exynos: Add spinlocks to irq_mask and irq_unmask Doug Anderson
2013-06-12 17:33 ` [PATCH 2/3] pinctrl: exynos: reorder xyz_irq_unmask() so future patch can ack Doug Anderson
2013-06-13 11:14   ` Tomasz Figa
2013-06-13 12:01   ` Kukjin Kim
2013-06-13 12:32   ` Linus Walleij
2013-06-13 16:43     ` Doug Anderson
2013-06-12 17:33 ` [PATCH 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking Doug Anderson
2013-06-13 10:54   ` Tomasz Figa
2013-06-13 16:34     ` Doug Anderson
2013-06-13 16:40       ` Tomasz Figa
2013-06-13 12:04   ` Kukjin Kim [this message]
2013-06-13 16:38     ` Doug Anderson
2013-06-13 16:42       ` Tomasz Figa
2013-06-13 16:50         ` Doug Anderson
2013-06-13 23:13           ` Kukjin Kim
2013-06-14  0:00             ` Doug Anderson
2013-06-14  0:18               ` Kukjin Kim
2013-06-13 12:34   ` Linus Walleij
2013-06-13 11:03 ` [PATCH 1/3] pinctrl: exynos: Add spinlocks to irq_mask and irq_unmask Tomasz Figa
2013-06-13 12:00 ` Kukjin Kim
2013-06-13 12:29 ` Linus Walleij
2013-06-13 16:38 ` [PATCH v2 3/3] pinctrl: exynos: ack level-triggered interrupts before unmasking Doug Anderson
2013-06-13 16:44   ` Tomasz Figa
2013-06-13 18:20   ` Linus Walleij
2013-06-17 16:56     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='150901ce682e$1c3fca50$54bf5ef0$%kim@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=dianders@chromium.org \
    --cc=eunki_kim@samsung.com \
    --cc=ilho215.lee@samsung.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=semenzato@chromium.org \
    --cc=sjg@chromium.org \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox