From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752658AbdJ0M5X (ORCPT ); Fri, 27 Oct 2017 08:57:23 -0400 Received: from esa3.hgst.iphmx.com ([216.71.153.141]:19539 "EHLO esa3.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752560AbdJ0M5U (ORCPT ); Fri, 27 Oct 2017 08:57:20 -0400 X-IronPort-AV: E=Sophos;i="5.44,304,1505750400"; d="scan'208";a="60179399" From: Bart Van Assche To: "keescook@chromium.org" CC: "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "varun@chelsio.com" , "target-devel@vger.kernel.org" , "jiangyilism@gmail.com" , "nab@linux-iscsi.org" Subject: Re: [PATCH v2] target/iscsi: Convert timers to use timer_setup() Thread-Topic: [PATCH v2] target/iscsi: Convert timers to use timer_setup() Thread-Index: AQHTTwS2A/LKCVfRgEmiJimW978EV6L3qCuA Date: Fri, 27 Oct 2017 12:57:16 +0000 Message-ID: <1509109031.3135.1.camel@wdc.com> References: <20171027091930.GA14728@beast> In-Reply-To: <20171027091930.GA14728@beast> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [37.205.56.236] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BY1PR0401MB1531;20:wZlGJn72zLK78/oYEytq9k/oQkwBxQFUYoEIkHyegKpVY9lX7EWV35Mo/vpR9VnClvpzMAlBd2toUTtYGkQoK0C8WKcm5TM8KJcxEOdgJS66fQ3Gmgz/FipSmtuZvGF9wpZrar2Ahvhn8t87UZtqfiINxHxBTFcXLrmsHJRKz/o= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 7a94440a-44d2-496b-aa0d-08d51d3a407f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603199);SRVR:BY1PR0401MB1531; x-ms-traffictypediagnostic: BY1PR0401MB1531: wdcipoutbound: EOP-TRUE x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(10201501046)(3002001)(93006095)(93001095)(3231020)(6055026)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123562025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BY1PR0401MB1531;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BY1PR0401MB1531; x-forefront-prvs: 0473A03F3F x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(346002)(376002)(377424004)(24454002)(199003)(189002)(86362001)(72206003)(3280700002)(478600001)(68736007)(229853002)(25786009)(81166006)(5660300001)(2950100002)(6916009)(1730700003)(2906002)(8936002)(6436002)(6506006)(7736002)(81156014)(8676002)(305945005)(6486002)(50986999)(99286003)(101416001)(103116003)(5640700003)(6512007)(6246003)(54356999)(66066001)(53936002)(76176999)(4326008)(105586002)(3660700001)(33646002)(106356001)(2351001)(39060400002)(36756003)(2900100001)(14454004)(189998001)(5250100002)(3846002)(2501003)(6116002)(316002)(54906003)(4001150100001)(102836003)(97736004);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR0401MB1531;H:BY1PR0401MB1532.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <21992BEF2662F4469E182F065BE27AEF@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a94440a-44d2-496b-aa0d-08d51d3a407f X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2017 12:57:16.7553 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0401MB1531 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v9RCvThU001025 On Fri, 2017-10-27 at 02:19 -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. Includes a fix for correcting an > on-stack timer usage. Hello Kees, These changes look good to me but I would like to test this patch. Is there a tree available somewhere that includes this patch? Thanks, Bart.