public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	Stephen Brennan <stephen@brennan.io>
Cc: Gilad Ben-Yossef <gilad@benyossef.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-crypto@vger.kernel.org,
	driverdev-devel@linuxdriverproject.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: ccree: Fix indentation in ssi_buffer_mgr.c
Date: Fri, 27 Oct 2017 07:23:58 -0700	[thread overview]
Message-ID: <1509114238.1914.4.camel@perches.com> (raw)
In-Reply-To: <20171027083247.sdsdwjiyhyflvjug@mwanda>

On Fri, 2017-10-27 at 11:32 +0300, Dan Carpenter wrote:
> On Thu, Oct 26, 2017 at 06:53:42PM -0700, Stephen Brennan wrote:
> > In particular, fixes some over-indented if statement bodies as well as a
> > couple lines indented with spaces. checkpatch.pl now reports no warnings
> > on this file other than 80 character warnings.
[]
> > diff --git a/drivers/staging/ccree/ssi_buffer_mgr.c b/drivers/staging/ccree/ssi_buffer_mgr.c
[]
> > @@ -1029,10 +1029,10 @@ static inline int ssi_buffer_mgr_prepare_aead_data_mlli(
> >  			 * verification is made by CPU compare in order to simplify
> >  			 * MAC verification upon request completion
> >  			 */
> > -			  u32 size_to_skip = req->assoclen;
> > +			u32 size_to_skip = req->assoclen;
> >  
> > -			  if (areq_ctx->is_gcm4543)
> > -				  size_to_skip += crypto_aead_ivsize(tfm);
> > +			if (areq_ctx->is_gcm4543)
> > +				size_to_skip += crypto_aead_ivsize(tfm);
> >  
> >  			  ssi_buffer_mgr_copy_scatterlist_portion(
> >  				dev, areq_ctx->backup_mac, req->src,
> 
> But then ssi_buffer_mgr_copy_scatterlist_portion() is still not indented
> correctly.

The latest version of checkpatch should bleat something on the
	...scatterlist_portion(
line

  reply	other threads:[~2017-10-27 14:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-27  1:53 [PATCH] staging: ccree: Fix indentation in ssi_buffer_mgr.c Stephen Brennan
2017-10-27  8:32 ` Dan Carpenter
2017-10-27 14:23   ` Joe Perches [this message]
2017-10-27 14:42     ` Stephen Brennan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1509114238.1914.4.camel@perches.com \
    --to=joe@perches.com \
    --cc=dan.carpenter@oracle.com \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=gilad@benyossef.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stephen@brennan.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox