From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751460AbdJ0OYE (ORCPT ); Fri, 27 Oct 2017 10:24:04 -0400 Received: from smtprelay0232.hostedemail.com ([216.40.44.232]:39263 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750919AbdJ0OYC (ORCPT ); Fri, 27 Oct 2017 10:24:02 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:2731:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3871:4250:4321:5007:7903:10004:10400:10848:11026:11232:11658:11914:12043:12438:12740:12760:12895:13069:13132:13161:13229:13231:13311:13357:13439:14096:14097:14181:14659:14721:21080:21627:30054:30069:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: rod01_22ea760a14263 X-Filterd-Recvd-Size: 2188 Message-ID: <1509114238.1914.4.camel@perches.com> Subject: Re: [PATCH] staging: ccree: Fix indentation in ssi_buffer_mgr.c From: Joe Perches To: Dan Carpenter , Stephen Brennan Cc: Gilad Ben-Yossef , Greg Kroah-Hartman , linux-crypto@vger.kernel.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Date: Fri, 27 Oct 2017 07:23:58 -0700 In-Reply-To: <20171027083247.sdsdwjiyhyflvjug@mwanda> References: <20171027015342.6345-1-stephen@brennan.io> <20171027083247.sdsdwjiyhyflvjug@mwanda> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-10-27 at 11:32 +0300, Dan Carpenter wrote: > On Thu, Oct 26, 2017 at 06:53:42PM -0700, Stephen Brennan wrote: > > In particular, fixes some over-indented if statement bodies as well as a > > couple lines indented with spaces. checkpatch.pl now reports no warnings > > on this file other than 80 character warnings. [] > > diff --git a/drivers/staging/ccree/ssi_buffer_mgr.c b/drivers/staging/ccree/ssi_buffer_mgr.c [] > > @@ -1029,10 +1029,10 @@ static inline int ssi_buffer_mgr_prepare_aead_data_mlli( > > * verification is made by CPU compare in order to simplify > > * MAC verification upon request completion > > */ > > - u32 size_to_skip = req->assoclen; > > + u32 size_to_skip = req->assoclen; > > > > - if (areq_ctx->is_gcm4543) > > - size_to_skip += crypto_aead_ivsize(tfm); > > + if (areq_ctx->is_gcm4543) > > + size_to_skip += crypto_aead_ivsize(tfm); > > > > ssi_buffer_mgr_copy_scatterlist_portion( > > dev, areq_ctx->backup_mac, req->src, > > But then ssi_buffer_mgr_copy_scatterlist_portion() is still not indented > correctly. The latest version of checkpatch should bleat something on the ...scatterlist_portion( line