From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752358AbdJ0Q7e (ORCPT ); Fri, 27 Oct 2017 12:59:34 -0400 Received: from smtp.polymtl.ca ([132.207.4.11]:54648 "EHLO smtp.polymtl.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750962AbdJ0Q7b (ORCPT ); Fri, 27 Oct 2017 12:59:31 -0400 X-Greylist: delayed 695 seconds by postgrey-1.27 at vger.kernel.org; Fri, 27 Oct 2017 12:59:31 EDT Message-ID: <1509122847.11787.5.camel@polymtl.ca> Subject: [PATCH] init/main.c: check for null pointer before calling initcall From: Abderrahmane Benbachir To: linux-kernel@vger.kernel.org Cc: mingo@kernel.org, akpm@linux-foundation.org, tglx@linutronix.de, keescook@chromium.org, jeyu@redhat.com, rostedt@goodmis.org, mhocko@suse.com, viresh.kumar@linaro.org, thomas.lendacky@amd.com Date: Fri, 27 Oct 2017 12:47:27 -0400 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (dyn44.dorsal.polymtl.ca [132.207.72.44]) at Fri, 27 Oct 2017 16:47:27 +0000 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Simple check to prevent kernel panic when initcall does not exit Signed-off-by: Abderrahmane Benbachir --- init/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/init/main.c b/init/main.c index 0ee9c6866ada..220fd2822b61 100644 --- a/init/main.c +++ b/init/main.c @@ -817,6 +817,9 @@ int __init_or_module do_one_initcall(initcall_t fn) int ret; char msgbuf[64]; + if (unlikely(!fn)) + return -EFAULT; + if (initcall_blacklisted(fn)) return -EPERM; -- 2.11.0