From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753993AbdJaSMg (ORCPT ); Tue, 31 Oct 2017 14:12:36 -0400 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:34720 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753067AbdJaSMc (ORCPT ); Tue, 31 Oct 2017 14:12:32 -0400 X-IronPort-AV: E=Sophos;i="5.44,325,1505750400"; d="scan'208";a="60331409" From: Bart Van Assche To: "Himanshu.Madhani@cavium.com" , "martin.petersen@oracle.com" CC: "keescook@chromium.org" , "jejb@linux.vnet.ibm.com" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "qla2xxx-upstream@cavium.com" Subject: Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup() Thread-Topic: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup() Thread-Index: AQHTTXlETgQEZ2O9zEiEgwXDeKItnaL+JPJNgAAlS4CAAAJtAA== Date: Tue, 31 Oct 2017 18:12:27 +0000 Message-ID: <1509473546.12927.5.camel@wdc.com> References: <20171025100737.GA145097@beast> <16733DFA-7339-4F77-9125-E8845C4FCD6F@cavium.com> In-Reply-To: <16733DFA-7339-4F77-9125-E8845C4FCD6F@cavium.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [63.163.107.100] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1534;20:E7DovPkiD10VFEAk8zz6tvqWrsMNRRlgUPUFM6y6eLArM8qCMxbCEpexT/CWsCROYhln3T+mqqsGhsR0sg8CYixMNcOWJ2+WzYBuW8H667XBal83oERQ1e7UN1XdmkmryllKQ3+2SbUUzKzK+uqHpBOb72JFMWmwVjUDiJJcNms= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 272ef830-aa2c-4777-7b15-08d5208af1fb x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(48565401081)(2017052603199);SRVR:CY1PR0401MB1534; x-ms-traffictypediagnostic: CY1PR0401MB1534: wdcipoutbound: EOP-TRUE x-exchange-antispam-report-test: UriScan:(146099531331640); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3231020)(93006095)(93001095)(3002001)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123558100)(20161123564025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR0401MB1534;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR0401MB1534; x-forefront-prvs: 04772EA191 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(376002)(39860400002)(346002)(199003)(377424004)(189002)(52314003)(24454002)(68736007)(76176999)(54356999)(77096006)(50986999)(2900100001)(6436002)(3660700001)(6486002)(101416001)(6506006)(229853002)(2501003)(305945005)(7736002)(4001150100001)(97736004)(189998001)(3280700002)(81166006)(81156014)(8676002)(2906002)(14454004)(8936002)(6116002)(106356001)(3846002)(102836003)(86362001)(5660300001)(54906003)(66066001)(4326008)(316002)(110136005)(2950100002)(478600001)(99286003)(53936002)(72206003)(36756003)(6246003)(6512007)(103116003)(33646002)(105586002)(25786009)(53546010);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1534;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <57AB9274636DE44589B7D2978B20A14C@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 272ef830-aa2c-4777-7b15-08d5208af1fb X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2017 18:12:27.8752 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1534 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v9VICfKB023205 On Tue, 2017-10-31 at 18:03 +0000, Madhani, Himanshu wrote: > On Oct 31, 2017, at 8:49 AM, Martin K. Petersen wrote: > > > In preparation for unconditionally passing the struct timer_list > > > pointer to all timer callbacks, switch to using the new timer_setup() > > > and from_timer() to pass the timer pointer explicitly. > > > > Cavium folks: Please verify! > > I’ve checked on my setup and i am seeing regression with this patch applied. > > Driver load locks up the system with this patch applied. > > NACK That feedback is not very helpful ... Anyway, what kernel source tree did you use in your testing? I may be able to free up some time to look into this myself. Bart.