From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755237AbdKAUYJ (ORCPT ); Wed, 1 Nov 2017 16:24:09 -0400 Received: from smtprelay0043.hostedemail.com ([216.40.44.43]:35822 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755211AbdKAUYG (ORCPT ); Wed, 1 Nov 2017 16:24:06 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2691:2828:3138:3139:3140:3141:3142:3353:3622:3865:3867:3868:3870:3871:4321:5007:7903:8957:9010:9545:10004:10400:10848:11026:11232:11658:11914:12296:12740:12760:12895:13069:13311:13357:13439:14180:14181:14659:14721:21080:21627:30054:30064:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: lace26_7abedc2ae5857 X-Filterd-Recvd-Size: 2329 Message-ID: <1509567842.31043.59.camel@perches.com> Subject: Re: [PATCH] scripts: warn about invalid MAINTAINERS patterns From: Joe Perches To: Augie Fackler , Tom Saeger Cc: xen-devel , mercurial-devel@mercurial-scm.org, linux-kernel@vger.kernel.org Date: Wed, 01 Nov 2017 13:24:02 -0700 In-Reply-To: References: <20171031213740.25510-1-tom.saeger@oracle.com> <1509555005.31043.43.camel@perches.com> <20171101171124.7eqbght7nw6vj2oy@revenge.us.oracle.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-11-01 at 16:05 -0400, Augie Fackler wrote: > > On Nov 1, 2017, at 13:11, Tom Saeger wrote: > > > > On Wed, Nov 01, 2017 at 09:50:05AM -0700, Joe Perches wrote: > > > (add mercurial-devel and xen-devel to cc's) > > > > > > On Tue, 2017-10-31 at 16:37 -0500, Tom Saeger wrote: > > > > Add "--pattern-checks" option to get_maintainer.pl to warn about invalid > > > > "F" and "X" patterns found in MAINTAINERS file(s). > > > > > > Hey again Tom. > > > > > > About mercurial/hg. > > > > > > While as far as I know there hasn't been a mercurial tree > > > for the linux kernel sources in many years, I believe the > > > mercurial command to list files should be different. > > > > > > > my %VCS_cmds_hg = ( > > > > @@ -167,6 +169,7 @@ my %VCS_cmds_hg = ( > > > > "subject_pattern" => "^HgSubject: (.*)", > > > > "stat_pattern" => "^(\\d+)\t(\\d+)\t\$file\$", > > > > "file_exists_cmd" => "hg files \$file", > > > > + "list_files_cmd" => "hg files \$file", > > > > > > I think this should be > > > > > > "list_files_cmd" => "hg manifest -R \$file", > > > > Ok - I'll add to v2. > > Actually, I'd recommend `hg files` over `hg manifest` by a wide margin. why? hg files -R prefixes all the output hg manifest -R output is unprefixed