From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755739AbdKBPBh (ORCPT ); Thu, 2 Nov 2017 11:01:37 -0400 Received: from esa2.hgst.iphmx.com ([68.232.143.124]:45493 "EHLO esa2.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755455AbdKBPBd (ORCPT ); Thu, 2 Nov 2017 11:01:33 -0400 X-IronPort-AV: E=Sophos;i="5.44,434,1505750400"; d="scan'208";a="157058354" From: Bart Van Assche To: "arnd@arndb.de" , "axboe@kernel.dk" CC: "jejb@linux.vnet.ibm.com" , "davem@davemloft.net" , "linux-kernel@vger.kernel.org" , "hare@suse.com" , "martin.petersen@oracle.com" , "linux-ide@vger.kernel.org" , "linux-scsi@vger.kernel.org" Subject: Re: [PATCH] block: fix CDROM dependency on BLK_DEV Thread-Topic: [PATCH] block: fix CDROM dependency on BLK_DEV Thread-Index: AQHTU8yQxM4G3H/tFUuyVfbrUMblWaMBJb8AgAAJhwA= Date: Thu, 2 Nov 2017 15:01:20 +0000 Message-ID: <1509634878.2484.5.camel@wdc.com> References: <20171102111952.4021454-1-arnd@arndb.de> <212c24f4-7329-f1f5-93c8-090727ed7226@kernel.dk> In-Reply-To: <212c24f4-7329-f1f5-93c8-090727ed7226@kernel.dk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [63.163.107.100] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1535;20:y5bn9mqApDJf7zUnS4C1zgWbE2CUNV39W+VAU4D+X1Tn2kncEVt/2Xbw7dNbXcAL8S7cT6QpKGa2JcEvyo/yQuXcRQrTysLdaPK+Pm2ImNZB+NKx3r8vAPrW0P48jNXqocGGtyOEexJV/IzvSD5YYozaZuOS3Wx5q8iIuuBKgY0= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 67262bde-16cb-45eb-67b5-08d52202937b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603199);SRVR:CY1PR0401MB1535; x-ms-traffictypediagnostic: CY1PR0401MB1535: wdcipoutbound: EOP-TRUE x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3231020)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR0401MB1535;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR0401MB1535; x-forefront-prvs: 047999FF16 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(346002)(376002)(39860400002)(199003)(189002)(377424004)(24454002)(105586002)(81166006)(305945005)(25786009)(106356001)(33646002)(8676002)(81156014)(36756003)(6116002)(4326008)(3846002)(102836003)(189998001)(97736004)(6246003)(99286004)(8936002)(3280700002)(2900100001)(3660700001)(68736007)(6436002)(7736002)(229853002)(6486002)(77096006)(66066001)(76176999)(50986999)(54356999)(72206003)(5660300001)(6506006)(110136005)(54906003)(478600001)(2501003)(14454004)(53936002)(316002)(2906002)(53546010)(86362001)(103116003)(101416001)(6512007)(2950100002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1535;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <4468D533762A8E4A8E18E259DFBE8F28@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67262bde-16cb-45eb-67b5-08d52202937b X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2017 15:01:20.1941 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1535 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vA2F1mkQ010638 On Thu, 2017-11-02 at 08:27 -0600, Jens Axboe wrote: > On 11/02/2017 05:19 AM, Arnd Bergmann wrote: > > After the cdrom cleanup, I get randconfig warnings for some configurations: > > > > warning: (BLK_DEV_IDECD && BLK_DEV_SR) selects CDROM which has unmet direct dependencies (BLK_DEV) > > > > This adds an explicit BLK_DEV dependency for both drivers. The other > > drivers that select 'CDROM' already have this and don't need a change. > > Thanks Arnd, applied. Hello Jens, Can you wait at least 24 hours after a patch has been posted before applying it such those who want to post review comments have a chance to do that? Thanks, Bart.