From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753236AbdKFJxV (ORCPT <rfc822;w@1wt.eu>);
        Mon, 6 Nov 2017 04:53:21 -0500
Received: from mx2.suse.de ([195.135.220.15]:47822 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752058AbdKFJxT (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 6 Nov 2017 04:53:19 -0500
Message-ID: <1509961757.2024.21.camel@suse.com>
Subject: Re: [PATCH] net: usb: asix: fill null-ptr-deref in asix_suspend
From: Oliver Neukum <oneukum@suse.com>
To: Andrey Konovalov <andreyknvl@google.com>, allan <allan@asix.com.tw>,
        Colin Ian King <colin.king@canonical.com>,
        "David S . Miller" <davem@davemloft.net>,
        Philippe Reynes <tremyfr@gmail.com>,
        Greg Ungerer <gerg@linux-m68k.org>,
        Dean Jenkins <Dean_Jenkins@mentor.com>,
        Peter Chen <peter.chen@nxp.com>, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org, netdev@vger.kernel.org
Cc: Dmitry Vyukov <dvyukov@google.com>, Kostya Serebryany <kcc@google.com>
Date: Mon, 06 Nov 2017 10:49:17 +0100
In-Reply-To: <9e768a837391af216cf1d2c8ac08af41f28cb147.1509654127.git.andreyknvl@google.com>
References: <9e768a837391af216cf1d2c8ac08af41f28cb147.1509654127.git.andreyknvl@google.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.20.5 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Donnerstag, den 02.11.2017, 21:26 +0100 schrieb Andrey Konovalov:
> When asix_suspend() is called dev->driver_priv might not have been
> assigned a value, so we need to check that it's not NULL.
> 
> Found by syzkaller.

Hi,

1. if that happens on suspend, it will also happen on resume
2. Will a device work after that? The appropriate fix may be to wait
until the device is properly initialized.

	Regards
		Oliver