From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754636AbdKFSck (ORCPT ); Mon, 6 Nov 2017 13:32:40 -0500 Received: from smtprelay0202.hostedemail.com ([216.40.44.202]:54312 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752240AbdKFSci (ORCPT ); Mon, 6 Nov 2017 13:32:38 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:857:960:973:981:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3870:3872:4321:5007:7903:8603:8879:10004:10400:10848:11026:11232:11658:11914:12043:12048:12114:12296:12438:12740:12760:12895:13069:13095:13255:13311:13357:13439:14659:14721:21080:21212:21433:21434:21627:30012:30030:30054:30075:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:4,LUA_SUMMARY:none X-HE-Tag: join97_16983849d1e14 X-Filterd-Recvd-Size: 2427 Message-ID: <1509993153.2431.48.camel@perches.com> Subject: Re: [PATCH v2] video: atmel_lcdfb: Use unique error messages in atmel_lcdfb_of_init() From: Joe Perches To: SF Markus Elfring , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz , Nicolas Ferre Cc: LKML , kernel-janitors@vger.kernel.org Date: Mon, 06 Nov 2017 10:32:33 -0800 In-Reply-To: References: <2db677d2-ad4e-1f79-344b-dfa38ce948c9@users.sourceforge.net> <5477205e-2067-de4f-8736-71a2c9dc1653@microchip.com> <8d297cae-5dd1-d345-8d9d-9bf3ec32d4f8@users.sourceforge.net> <2d650d87-034c-d05b-b3aa-f689f25ab184@microchip.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-11-06 at 19:14 +0100, SF Markus Elfring wrote: > A duplicate error message was used so far in this function implementation. > Thus use a consistent message format instead together with property names > where constant merging can be applied by the compiler in four cases. [] > diff --git a/drivers/video/fbdev/atmel_lcdfb.c b/drivers/video/fbdev/atmel_lcdfb.c [] > @@ -1021,6 +1021,8 @@ static void atmel_lcdfb_power_control_gpio(struct atmel_lcdfb_pdata *pdata, int > gpio_set_value(og->gpio, on); > } > > +static char const property_failure[] = "failed to get property %s\n"; Yuck. This makes it harder to grep the sources. Just use the normal format string in each place. > + > static int atmel_lcdfb_of_init(struct atmel_lcdfb_info *sinfo) > { > struct fb_info *info = sinfo->info; > @@ -1048,25 +1050,25 @@ static int atmel_lcdfb_of_init(struct atmel_lcdfb_info *sinfo) > > ret = of_property_read_u32(display_np, "bits-per-pixel", &var->bits_per_pixel); > if (ret < 0) { > - dev_err(dev, "failed to get property bits-per-pixel\n"); > + dev_err(dev, property_failure, "bits-per-pixel"); This likely doesn't even save any code size.