Re: [PATCH v9 07/17] PM / devfreq: tegra30: Support interconnect and OPPs from device-tree

Dmitry Osipenko
2020-11-19T21:04:36Z

18.11.2020 07:21, Viresh Kumar пишет:
...
>>>> + /* legacy device-trees don't have OPP table and must be updated */
>>>> + if (!device_property_present(&pdev->dev, "operating-points-v2")) {
>>>> + dev_err(&pdev->dev,
>>>> + "OPP table not found, please update your device tree\n");
>>>> + return -ENODEV;
>>>> + }
>>>> +
>>>
>>> You forgot to remove this ?
>>
>> Yes, good catch. I'm planning to replace this code with a common helper
>> sometime soon, so if there won't be another reasons to make a new
>> revision, then I'd prefer to keep it as-is for now.
>
> You should just replace this patch only with a version of V9.1 and you
> aren't really required to resend the whole series. And you should fix
> it before it gets merged. This isn't a formatting issue which we just
> let through. I trust you when you say that you will fix it, but this
> must be fixed now.
>

Should be easier to resend it all. I'll update it over the weekend, thanks.